From patchwork Tue Mar 19 20:19:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 10860317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1DC9214DE for ; Tue, 19 Mar 2019 20:20:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0209428DE6 for ; Tue, 19 Mar 2019 20:20:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA24C2966F; Tue, 19 Mar 2019 20:20:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E89A2959C for ; Tue, 19 Mar 2019 20:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfCSUUA (ORCPT ); Tue, 19 Mar 2019 16:20:00 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38588 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbfCSUUA (ORCPT ); Tue, 19 Mar 2019 16:20:00 -0400 Received: by mail-lj1-f194.google.com with SMTP id x13so250878ljj.5; Tue, 19 Mar 2019 13:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QAp0KuCd+VwXHGjzKhbOPSvfhdsI4XdE3B+BZLnU0mk=; b=j6s9im/uW0PjIPrC7LisBb4yt4hAP9QE0ccseZ//LilK2ZfaIxgGcC8Tgobaztjlln Nyi9NePlyThsQ4U3Ie6sjGo0+OklAqXc21M1zUbC10pqUIhlqCA7S07H/qMdD5egUjk0 nNN9BzCUvIKsVdPUBn81Bkn69N3nmmlSYUjQjccWbG9Q38tlLjIGdnZZK+bXY1ZPon7I L0wGnqXiPWcMRjFQr9z0NOW7AMQc2/18EQqQBE2k6IlSmkIvmlTiW/i2UZ8Ide6BEX6V T0L/zZAP16pUdtHOjs0zJDd4A/JW+cbdoKn5wueQhFC4AMKznsPxS5yA3HSeCsYzHpyw 7ohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QAp0KuCd+VwXHGjzKhbOPSvfhdsI4XdE3B+BZLnU0mk=; b=Nlf79ZwyNn3KpJFpG8MqD5FA1a3up3jDdu9DQgI2Hz4v8FEsRpQYteFv3qVvKLqOlN Qka6XX6D7AAUwzYA4eNoCGTXU22EyUkLTRzdaS6u1J1SPt1d1UQSzebtg0ibJRuaXnEg QcCE84/6RaxRF7NY3q9g3RxkfvWMC8QsIgDjVyHh2Txpr9i9y3XQ9xJpo9HzT839828c d9sGqqzxVgKvB0pXRm731UeRr8iC7mIZeY1fcjZqQn2Gs9EP8Y//s5Di312+jt6cCHId o3yjBMuOJtvcQtE0AqXhL3l/nuF/H+eJiccuTbj7GCAWWhjkZVICVm6tMBE40b1pPSZQ 2EJA== X-Gm-Message-State: APjAAAV72EM0i/U1TMyClw3NxZm4rG9YoGD4UdBA5LVW4TcE253mo+kS +gUO0iE+0Qxqvhf2a4nqWhI= X-Google-Smtp-Source: APXvYqygDDUfXYqH+4ugtLxN68Uudfb9H3IzyKHm/PL3yUCwrxxR86FDcwIcbV7LqN/S4wCBQg8TgA== X-Received: by 2002:a2e:899a:: with SMTP id c26mr13444322lji.192.1553026798116; Tue, 19 Mar 2019 13:19:58 -0700 (PDT) Received: from z50.gdansk-morena.vectranet.pl (109241207190.gdansk.vectranet.pl. [109.241.207.190]) by smtp.gmail.com with ESMTPSA id i24sm2864410lfl.73.2019.03.19.13.19.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 13:19:57 -0700 (PDT) From: Janusz Krzysztofik To: Tony Lindgren Cc: Aaro Koskinen , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Janusz Krzysztofik , stable@vger.kernel.org Subject: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation Date: Tue, 19 Mar 2019 21:19:52 +0100 Message-Id: <20190319201952.1309-1-jmkrzyszt@gmail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In order to request dynamic allocationn of GPIO IDs, a negative number should be passed as a base GPIO ID via platform data. Unfortuntely, commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers") didn't follow that rule while switching to dynamically allocated GPIO IDs for Amstrad Delta latches, making their IDs overlapping with those already assigned to OMAP GPIO devices. Fix it. Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers") Signed-off-by: Janusz Krzysztofik Cc: stable@vger.kernel.org Acked-by: Aaro Koskinen --- arch/arm/mach-omap1/board-ams-delta.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c index be30c3c061b4..1b15d593837e 100644 --- a/arch/arm/mach-omap1/board-ams-delta.c +++ b/arch/arm/mach-omap1/board-ams-delta.c @@ -182,6 +182,7 @@ static struct resource latch1_resources[] = { static struct bgpio_pdata latch1_pdata = { .label = LATCH1_LABEL, + .base = -1, .ngpio = LATCH1_NGPIO, }; @@ -219,6 +220,7 @@ static struct resource latch2_resources[] = { static struct bgpio_pdata latch2_pdata = { .label = LATCH2_LABEL, + .base = -1, .ngpio = LATCH2_NGPIO, };