| Message ID | 20190623151313.970-5-tranmanphong@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cleanup cppcheck signed shifting errors | expand |
On Sun, 23 Jun 2019 at 17:14, Phong Tran <tranmanphong@gmail.com> wrote: > > [arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit > value by 31 bits is undefined behaviour > > Signed-off-by: Phong Tran <tranmanphong@gmail.com> > --- > arch/arm/mach-exynos/suspend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Let's switch to BIT macro. It will solve the problem and is preferred way of coding. Best regards, Krzysztof
diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index be122af0de8f..8b93d130f79c 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -285,7 +285,7 @@ static void exynos_pm_set_wakeup_mask(void) * Set wake-up mask registers * EXYNOS_EINT_WAKEUP_MASK is set by pinctrl driver in late suspend. */ - pmu_raw_writel(exynos_irqwake_intmask & ~(1 << 31), S5P_WAKEUP_MASK); + pmu_raw_writel(exynos_irqwake_intmask & ~(1U << 31), S5P_WAKEUP_MASK); } static void exynos_pm_enter_sleep_mode(void)
[arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Phong Tran <tranmanphong@gmail.com> --- arch/arm/mach-exynos/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)