diff mbox series

[net,v2,2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

Message ID 20200821134912.30008-2-m-karicheri2@ti.com
State New
Headers show
Series [net,v2,1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port | expand

Commit Message

Murali Karicheri Aug. 21, 2020, 1:49 p.m. UTC
To flush the vid + mc entries from ALE, which is required when a VLAN
interface is removed, driver needs to call cpsw_ale_flush_multicast()
with ALE_PORT_HOST for port mask as these entries are added only for
host port. Without this, these entries remain in the ALE table even
after removing the VLAN interface. cpsw_ale_flush_multicast() calls
cpsw_ale_flush_mcast which expects a port mask to do the job.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 v2: Dropped 3/3 and re-sending as it need more work
 drivers/net/ethernet/ti/cpsw_new.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jesse Brandeburg Aug. 21, 2020, 8 p.m. UTC | #1
Murali Karicheri wrote:

> To flush the vid + mc entries from ALE, which is required when a VLAN
> interface is removed, driver needs to call cpsw_ale_flush_multicast()
> with ALE_PORT_HOST for port mask as these entries are added only for
> host port. Without this, these entries remain in the ALE table even
> after removing the VLAN interface. cpsw_ale_flush_multicast() calls
> cpsw_ale_flush_mcast which expects a port mask to do the job.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>

Patch looks good but please resend with a Fixes: tag.
Murali Karicheri Aug. 24, 2020, 11:09 a.m. UTC | #2
On 8/21/20 4:00 PM, Jesse Brandeburg wrote:
> Murali Karicheri wrote:
> 
>> To flush the vid + mc entries from ALE, which is required when a VLAN
>> interface is removed, driver needs to call cpsw_ale_flush_multicast()
>> with ALE_PORT_HOST for port mask as these entries are added only for
>> host port. Without this, these entries remain in the ALE table even
>> after removing the VLAN interface. cpsw_ale_flush_multicast() calls
>> cpsw_ale_flush_mcast which expects a port mask to do the job.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> 
> Patch looks good but please resend with a Fixes: tag.
> 
Sure will do
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 1247d35d42ef..8d0a2bc7128d 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -1044,7 +1044,7 @@  static int cpsw_ndo_vlan_rx_kill_vid(struct net_device *ndev,
 			   HOST_PORT_NUM, ALE_VLAN, vid);
 	cpsw_ale_del_mcast(cpsw->ale, priv->ndev->broadcast,
 			   0, ALE_VLAN, vid);
-	cpsw_ale_flush_multicast(cpsw->ale, 0, vid);
+	cpsw_ale_flush_multicast(cpsw->ale, ALE_PORT_HOST, vid);
 err:
 	pm_runtime_put(cpsw->dev);
 	return ret;