diff mbox series

[10/42] mfd: intel_msic: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-10-krzk@kernel.org (mailing list archive)
State New
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/intel_msic.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Andy Shevchenko Sept. 22, 2020, 8:22 a.m. UTC | #1
On Mon, Sep 21, 2020 at 11:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/mfd/intel_msic.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
> index bb24c2a07900..e9944a81dc44 100644
> --- a/drivers/mfd/intel_msic.c
> +++ b/drivers/mfd/intel_msic.c
> @@ -317,8 +317,9 @@ static int intel_msic_init_devices(struct intel_msic *msic)
>                 if (!pdata->irq[i])
>                         continue;
>
> -               ret = mfd_add_devices(&pdev->dev, -1, &msic_devs[i], 1, NULL,
> -                                     pdata->irq[i], NULL);
> +               ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> +                                     &msic_devs[i], 1, NULL, pdata->irq[i],
> +                                     NULL);
>                 if (ret)
>                         goto fail;
>         }
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
index bb24c2a07900..e9944a81dc44 100644
--- a/drivers/mfd/intel_msic.c
+++ b/drivers/mfd/intel_msic.c
@@ -317,8 +317,9 @@  static int intel_msic_init_devices(struct intel_msic *msic)
 		if (!pdata->irq[i])
 			continue;
 
-		ret = mfd_add_devices(&pdev->dev, -1, &msic_devs[i], 1, NULL,
-				      pdata->irq[i], NULL);
+		ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
+				      &msic_devs[i], 1, NULL, pdata->irq[i],
+				      NULL);
 		if (ret)
 			goto fail;
 	}