diff mbox series

[17/42] mfd: max77693: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-17-krzk@kernel.org (mailing list archive)
State New
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/max77693.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chanwoo Choi Sept. 28, 2020, 3:16 a.m. UTC | #1
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/mfd/max77693.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 596ed85cab3b..02fbdf0a66c3 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -274,7 +274,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
>  
>  	pm_runtime_set_active(max77693->dev);
>  
> -	ret = mfd_add_devices(max77693->dev, -1, max77693_devs,
> +	ret = mfd_add_devices(max77693->dev, PLATFORM_DEVID_NONE, max77693_devs,
>  			      ARRAY_SIZE(max77693_devs), NULL, 0, NULL);
>  	if (ret < 0)
>  		goto err_mfd;
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
diff mbox series

Patch

diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 596ed85cab3b..02fbdf0a66c3 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -274,7 +274,7 @@  static int max77693_i2c_probe(struct i2c_client *i2c,
 
 	pm_runtime_set_active(max77693->dev);
 
-	ret = mfd_add_devices(max77693->dev, -1, max77693_devs,
+	ret = mfd_add_devices(max77693->dev, PLATFORM_DEVID_NONE, max77693_devs,
 			      ARRAY_SIZE(max77693_devs), NULL, 0, NULL);
 	if (ret < 0)
 		goto err_mfd;