diff mbox series

[06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-6-krzk@kernel.org (mailing list archive)
State New
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/bcm2835-pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Florian Fainelli Sept. 21, 2020, 9:12 p.m. UTC | #1
On 9/21/20 1:49 PM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Nicolas Saenz Julienne Sept. 22, 2020, 10:34 a.m. UTC | #2
On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

>  drivers/mfd/bcm2835-pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
> index 42fe67f1538e..a76014512bde 100644
> --- a/drivers/mfd/bcm2835-pm.c
> +++ b/drivers/mfd/bcm2835-pm.c
> @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  	if (IS_ERR(pm->base))
>  		return PTR_ERR(pm->base);
>  
> -	ret = devm_mfd_add_devices(dev, -1,
> +	ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  				   bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs),
>  				   NULL, 0, NULL);
>  	if (ret)
> @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  		if (IS_ERR(pm->asb))
>  			return PTR_ERR(pm->asb);
>  
> -		ret = devm_mfd_add_devices(dev, -1,
> +		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  					   bcm2835_power_devs,
>  					   ARRAY_SIZE(bcm2835_power_devs),
>  					   NULL, 0, NULL);
diff mbox series

Patch

diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
index 42fe67f1538e..a76014512bde 100644
--- a/drivers/mfd/bcm2835-pm.c
+++ b/drivers/mfd/bcm2835-pm.c
@@ -44,7 +44,7 @@  static int bcm2835_pm_probe(struct platform_device *pdev)
 	if (IS_ERR(pm->base))
 		return PTR_ERR(pm->base);
 
-	ret = devm_mfd_add_devices(dev, -1,
+	ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
 				   bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs),
 				   NULL, 0, NULL);
 	if (ret)
@@ -60,7 +60,7 @@  static int bcm2835_pm_probe(struct platform_device *pdev)
 		if (IS_ERR(pm->asb))
 			return PTR_ERR(pm->asb);
 
-		ret = devm_mfd_add_devices(dev, -1,
+		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
 					   bcm2835_power_devs,
 					   ARRAY_SIZE(bcm2835_power_devs),
 					   NULL, 0, NULL);