diff mbox series

ARM: dts: omap36xx: Remove turbo mode for 1GHz variants

Message ID 20210109163916.1247431-1-aford173@gmail.com (mailing list archive)
State New
Headers show
Series ARM: dts: omap36xx: Remove turbo mode for 1GHz variants | expand

Commit Message

Adam Ford Jan. 9, 2021, 4:39 p.m. UTC
Previously, the 1GHz variants were marked as a turbo,
because that variant has reduced thermal operating range.

Now that the thermal throttling is in place, it should be
safe to remove the turbo-mode from the 1GHz variants, because
the CPU will automatically slow if the thermal limit is reached.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

H. Nikolaus Schaller Jan. 9, 2021, 4:55 p.m. UTC | #1
Hi Adam,

> Am 09.01.2021 um 17:39 schrieb Adam Ford <aford173@gmail.com>:
> 
> Previously, the 1GHz variants were marked as a turbo,
> because that variant has reduced thermal operating range.
> 
> Now that the thermal throttling is in place, it should be
> safe to remove the turbo-mode from the 1GHz variants, because
> the CPU will automatically slow if the thermal limit is reached.

Subject and description may be misunderstood in a way that 1GHz
is now disabled.

Rather the 1GHz OPP is now permanently enabled and does no longer
need to be manuall enabled through something like
/sys/devices/system/cpu/cpufreq/boost.

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> index 3a5228562b0d..3451f9be104e 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> @@ -70,6 +70,7 @@ nand@0,0 {
> 		gpmc,device-width = <2>;
> 		#address-cells = <1>;
> 		#size-cells = <1>;
> +		status = "disabled";

this does not seem to match the description?

> 	};
> };
> 
> -- 
> 2.25.1
> 

BR,
Nikolaus
Adam Ford Jan. 9, 2021, 4:56 p.m. UTC | #2
On Sat, Jan 9, 2021 at 10:39 AM Adam Ford <aford173@gmail.com> wrote:
>
> Previously, the 1GHz variants were marked as a turbo,
> because that variant has reduced thermal operating range.
>
> Now that the thermal throttling is in place, it should be
> safe to remove the turbo-mode from the 1GHz variants, because
> the CPU will automatically slow if the thermal limit is reached.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
Sorry for the noise.  grabbed the wrong thing.

Please disregard.

> diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> index 3a5228562b0d..3451f9be104e 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> @@ -70,6 +70,7 @@ nand@0,0 {
>                 gpmc,device-width = <2>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> +               status = "disabled";
>         };
>  };
>
> --
> 2.25.1
>
Adam Ford Jan. 9, 2021, 5:03 p.m. UTC | #3
On Sat, Jan 9, 2021 at 10:58 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Hi Adam,
>
> > Am 09.01.2021 um 17:39 schrieb Adam Ford <aford173@gmail.com>:
> >
> > Previously, the 1GHz variants were marked as a turbo,
> > because that variant has reduced thermal operating range.
> >
> > Now that the thermal throttling is in place, it should be
> > safe to remove the turbo-mode from the 1GHz variants, because
> > the CPU will automatically slow if the thermal limit is reached.
>
> Subject and description may be misunderstood in a way that 1GHz
> is now disabled.
>
> Rather the 1GHz OPP is now permanently enabled and does no longer
> need to be manuall enabled through something like
> /sys/devices/system/cpu/cpufreq/boost.

I just sent a V2, before I saw this. I can send a V3 with your
feedback.  I just want to give Tony and/or others a chance to chime
in.

>
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > index 3a5228562b0d..3451f9be104e 100644
> > --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > @@ -70,6 +70,7 @@ nand@0,0 {
> >               gpmc,device-width = <2>;
> >               #address-cells = <1>;
> >               #size-cells = <1>;
> > +             status = "disabled";
>
> this does not seem to match the description?

I just sent an apology e-mail because I realized I grabbed the wrong file.

>
> >       };
> > };
> >
> > --
> > 2.25.1
> >
>
> BR,
> Nikolaus
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
index 3a5228562b0d..3451f9be104e 100644
--- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
+++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
@@ -70,6 +70,7 @@  nand@0,0 {
 		gpmc,device-width = <2>;
 		#address-cells = <1>;
 		#size-cells = <1>;
+		status = "disabled";
 	};
 };