diff mbox series

[2/3] video: omapfb: Remove WARN_ON(in_interrupt()).

Message ID 20210208223810.388502-3-bigeasy@linutronix.de (mailing list archive)
State New
Headers show
Series video: Remove in_interrupt() usage. | expand

Commit Message

Sebastian Andrzej Siewior Feb. 8, 2021, 10:38 p.m. UTC
From: "Ahmed S. Darwish" <a.darwish@linutronix.de>

dsi_sync_vc() uses in_interrupt() to create a warning if the function is
used in non-preemptible context.

The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

The wait_for_completion() function (used in dsi_sync_vc_vp() and
dsi_sync_vc_l4() has already a check if it is invoked from proper

Remove WARN_ON(in_interrupt()) from the driver.

Cc: linux-omap@vger.kernel.org
Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
 drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index dc34bb04b865c..df90091de75f8 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -2373,8 +2373,6 @@  static int dsi_sync_vc(struct platform_device *dsidev, int channel)
-	WARN_ON(in_interrupt());
 	if (!dsi_vc_is_enabled(dsidev, channel))
 		return 0;