diff mbox series

[04/11] ARM: dts: Configure interconnect target module for omap5 gpmc

Message ID 20210308151143.27793-5-tony@atomide.com (mailing list archive)
State New
Headers show
Series Update omap5 dts files to probe with genpd | expand

Commit Message

Tony Lindgren March 8, 2021, 3:11 p.m. UTC
We can now probe devices with device tree only configuration using
ti-sysc interconnect target module driver. Let's configure the
module, but keep the legacy "ti,hwmods" property to avoid new boot
time warnings. The legacy property will be removed in later patches
together with the legacy platform data.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap5.dtsi | 49 ++++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 16 deletions(-)

Comments

Rong Chen March 9, 2021, 6:58 a.m. UTC | #1
Hi Tony,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on omap/for-next balbi-usb/testing/next v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/Update-omap5-dts-files-to-probe-with-genpd/20210308-231425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce: make ARCH=arm dtbs_check

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/omap5.dtsi:186.31-32 syntax error
   FATAL ERROR: Unable to parse input tree


"dtcheck warnings: (new ones prefixed by >>)"
   make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-cm-t54.dtb] Error 1
   make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
   make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-uevm.dtb] Error 1
   make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-sbc-t54.dtb] Error 1
>> make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-cm-t54.dt.yaml] Error 1
>> make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-igep0050.dt.yaml] Error 1
   make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-sbc-t54.dt.yaml] Error 1
   make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-uevm.dt.yaml] Error 1
   make[2]: Target '__build' not remade because of errors.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Tony Lindgren March 9, 2021, 9:59 a.m. UTC | #2
* kernel test robot <rong.a.chen@intel.com> [210309 06:59]:
> Hi Tony,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on omap/for-next balbi-usb/testing/next v5.12-rc2 next-20210305]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/Update-omap5-dts-files-to-probe-with-genpd/20210308-231425
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> config: arm-defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce: make ARCH=arm dtbs_check
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> Error: arch/arm/boot/dts/omap5.dtsi:186.31-32 syntax error
>    FATAL ERROR: Unable to parse input tree
> 
> 
> "dtcheck warnings: (new ones prefixed by >>)"
>    make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-cm-t54.dtb] Error 1
>    make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>    make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-uevm.dtb] Error 1
>    make[2]: *** [scripts/Makefile.lib:336: arch/arm/boot/dts/omap5-sbc-t54.dtb] Error 1
> >> make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-cm-t54.dt.yaml] Error 1
> >> make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-igep0050.dt.yaml] Error 1
>    make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-sbc-t54.dt.yaml] Error 1
>    make[2]: *** [scripts/Makefile.lib:355: arch/arm/boot/dts/omap5-uevm.dt.yaml] Error 1
>    make[2]: Target '__build' not remade because of errors.


I think we can ignore this error, this patch depends on patch:

"[PATCH 3/4] clk: ti: omap5: Add missing gpmc and ocmc clkctrl"

Regards,

Tony
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -177,23 +177,40 @@  ocmcram: sram@40300000 {
 			reg = <0x40300000 0x20000>; /* 128k */
 		};
 
-		gpmc: gpmc@50000000 {
-			compatible = "ti,omap4430-gpmc";
-			reg = <0x50000000 0x1000>;
-			#address-cells = <2>;
-			#size-cells = <1>;
-			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
-			dmas = <&sdma 4>;
-			dma-names = "rxtx";
-			gpmc,num-cs = <8>;
-			gpmc,num-waitpins = <4>;
-			ti,hwmods = "gpmc";
-			clocks = <&l3_iclk_div>;
+		target-module@50000000 {
+			compatible = "ti,sysc-omap2", "ti,sysc";
+			reg = <0x50000000 4>,
+			      <0x50000010 4>,
+			      <0x50000014 4>;
+			reg-names = "rev", "sysc", "syss";
+			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>;
+			ti,syss-mask = <1>;
+			ti,no-idle-on-init;
+			clocks = <&l3main2_clkctrl OMAP5_L3_MAIN_2_GPMC_CLKCTRL 0>;
 			clock-names = "fck";
-			interrupt-controller;
-			#interrupt-cells = <2>;
-			gpio-controller;
-			#gpio-cells = <2>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0x50000000 0x50000000 0x00001000>, /* regs */
+				 <0x00000000 0x00000000 0x40000000>; /* data */
+
+			gpmc: gpmc@50000000 {
+				compatible = "ti,omap4430-gpmc";
+				reg = <0x50000000 0x1000>;
+				#address-cells = <2>;
+				#size-cells = <1>;
+				interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+				dmas = <&sdma 4>;
+				dma-names = "rxtx";
+				gpmc,num-cs = <8>;
+				gpmc,num-waitpins = <4>;
+				clock-names = "fck";
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-controller;
+				#gpio-cells = <2>;
+			};
 		};
 
 		target-module@55082000 {