diff mbox series

[-next] ARM: OMAP2+: Fix build warning when mmc_omap is not built

Message ID 20210401131533.998767-1-liuyongqiang13@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] ARM: OMAP2+: Fix build warning when mmc_omap is not built | expand

Commit Message

Yongqiang Liu April 1, 2021, 1:15 p.m. UTC
GCC reports the following warning with W=1:

arch/arm/mach-omap2/board-n8x0.c:325:19: warning:
variable 'index' set but not used [-Wunused-but-set-variable]
325 |  int bit, *openp, index;
    |                   ^~~~~

Fix this by moving CONFIG_MMC_OMAP to cover the rest codes
in the n8x0_mmc_callback().

Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
---
 arch/arm/mach-omap2/board-n8x0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren May 18, 2021, 6:27 a.m. UTC | #1
* Yongqiang Liu <liuyongqiang13@huawei.com> [210401 16:09]:
> GCC reports the following warning with W=1:
> 
> arch/arm/mach-omap2/board-n8x0.c:325:19: warning:
> variable 'index' set but not used [-Wunused-but-set-variable]
> 325 |  int bit, *openp, index;
>     |                   ^~~~~
> 
> Fix this by moving CONFIG_MMC_OMAP to cover the rest codes
> in the n8x0_mmc_callback().

Thanks applying into fixes.

Tony
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
index 418a61ecb827..5e86145db0e2 100644
--- a/arch/arm/mach-omap2/board-n8x0.c
+++ b/arch/arm/mach-omap2/board-n8x0.c
@@ -322,6 +322,7 @@  static int n8x0_mmc_get_cover_state(struct device *dev, int slot)
 
 static void n8x0_mmc_callback(void *data, u8 card_mask)
 {
+#ifdef CONFIG_MMC_OMAP
 	int bit, *openp, index;
 
 	if (board_is_n800()) {
@@ -339,7 +340,6 @@  static void n8x0_mmc_callback(void *data, u8 card_mask)
 	else
 		*openp = 0;
 
-#ifdef CONFIG_MMC_OMAP
 	omap_mmc_notify_cover_event(mmc_device, index, *openp);
 #else
 	pr_warn("MMC: notify cover event not available\n");