| Message ID | 20211123102607.13002-4-rogerq@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 23/11/2021 11:26, Roger Quadros wrote: > GPMC was not being visible if COMPILE_TEST is not enabled. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > drivers/memory/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > ... which was probably on purpose, similarly to many other SoC drivers which are selected by platform. Therefore there is no bug to fix here - lack of visibility is not a problem. Please document instead why you want to change it, e.g. why this is a problem or unwanted behavior. Best regards, Krzysztof
On 23/11/2021 21:43, Krzysztof Kozlowski wrote: > On 23/11/2021 11:26, Roger Quadros wrote: >> GPMC was not being visible if COMPILE_TEST is not enabled. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- >> drivers/memory/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > ... which was probably on purpose, similarly to many other SoC drivers > which are selected by platform. Therefore there is no bug to fix here - > lack of visibility is not a problem. Please document instead why you > want to change it, e.g. why this is a problem or unwanted behavior. > No strong enough reason. I'll drop this patch. cheers, -roger
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index 30bff6cb1b8d..da2af9c38fe3 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -103,8 +103,8 @@ config TI_EMIF temperature changes config OMAP_GPMC - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST - depends on OF_ADDRESS + bool "Texas Instruments OMAP SoC GPMC driver" + depends on OF_ADDRESS || COMPILE_TEST select GPIOLIB help This driver is for the General Purpose Memory Controller (GPMC)
GPMC was not being visible if COMPILE_TEST is not enabled. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/memory/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)