diff mbox series

[1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable

Message ID 20220326084331.28310-1-rogerq@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable | expand

Commit Message

Roger Quadros March 26, 2022, 8:43 a.m. UTC
So far for armv7 TI platforms, GPMC was being selected by
arch/arm/mach-* architecture Kconfig files.

For K3 platforms, GPMC is no longer required for basic boot
and cannot be always enabled by default by mach- Kconfig.

We need a way for user (or board defconfig) to enable
it if required so ake OMAP_GPMC Kconfig option always visible.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/memory/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vignesh Raghavendra March 26, 2022, 2:09 p.m. UTC | #1
Hi Roger,

On 26/03/22 2:13 pm, Roger Quadros wrote:
> So far for armv7 TI platforms, GPMC was being selected by
> arch/arm/mach-* architecture Kconfig files.
> 
> For K3 platforms, GPMC is no longer required for basic boot
> and cannot be always enabled by default by mach- Kconfig.
> 
> We need a way for user (or board defconfig) to enable
> it if required so ake OMAP_GPMC Kconfig option always visible.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  drivers/memory/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 30bff6cb1b8d..da2af9c38fe3 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -103,8 +103,8 @@ config TI_EMIF
>  	  temperature changes
>  
>  config OMAP_GPMC
> -	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> -	depends on OF_ADDRESS
> +	bool "Texas Instruments OMAP SoC GPMC driver"
> +	depends on OF_ADDRESS || COMPILE_TEST

Can we make this tristate now, so that driver can be built as module?

>  	select GPIOLIB
>  	help
>  	  This driver is for the General Purpose Memory Controller (GPMC)
Roger Quadros March 26, 2022, 2:36 p.m. UTC | #2
Hi Vignesh,

On 26/03/2022 16:09, Vignesh Raghavendra wrote:
> Hi Roger,
> 
> On 26/03/22 2:13 pm, Roger Quadros wrote:
>> So far for armv7 TI platforms, GPMC was being selected by
>> arch/arm/mach-* architecture Kconfig files.
>>
>> For K3 platforms, GPMC is no longer required for basic boot
>> and cannot be always enabled by default by mach- Kconfig.
>>
>> We need a way for user (or board defconfig) to enable
>> it if required so ake OMAP_GPMC Kconfig option always visible.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  drivers/memory/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
>> index 30bff6cb1b8d..da2af9c38fe3 100644
>> --- a/drivers/memory/Kconfig
>> +++ b/drivers/memory/Kconfig
>> @@ -103,8 +103,8 @@ config TI_EMIF
>>  	  temperature changes
>>  
>>  config OMAP_GPMC
>> -	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>> -	depends on OF_ADDRESS
>> +	bool "Texas Instruments OMAP SoC GPMC driver"
>> +	depends on OF_ADDRESS || COMPILE_TEST
> 
> Can we make this tristate now, so that driver can be built as module?

Sure, I'll give it a try.

> 
>>  	select GPIOLIB
>>  	help
>>  	  This driver is for the General Purpose Memory Controller (GPMC)

--
cheers,
-roger
diff mbox series

Patch

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 30bff6cb1b8d..da2af9c38fe3 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -103,8 +103,8 @@  config TI_EMIF
 	  temperature changes
 
 config OMAP_GPMC
-	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
-	depends on OF_ADDRESS
+	bool "Texas Instruments OMAP SoC GPMC driver"
+	depends on OF_ADDRESS || COMPILE_TEST
 	select GPIOLIB
 	help
 	  This driver is for the General Purpose Memory Controller (GPMC)