| Message ID | 20220427161126.647073-5-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dmaengine/ARM: use proper 'dma-channels/requests' properties | expand |
On Wed, Apr 27, 2022 at 06:11:24PM +0200, Krzysztof Kozlowski wrote: > The '#dma-channels' and '#dma-requests' properties were deprecated in > favor of these defined by generic dma-common DT bindings. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/am33xx.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index f6ec85d58dd1..55ffb0813ded 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 { > interrupts = <17>; > interrupt-names = "glue"; > #dma-cells = <2>; > - #dma-channels = <30>; > - #dma-requests = <256>; > + dma-channels = <30>; > + dma-requests = <256>; You could keep the old properties for compatibility and to apply immediately. > }; > }; > > -- > 2.32.0 > >
On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote: > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index f6ec85d58dd1..55ffb0813ded 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 { > > interrupts = <17>; > > interrupt-names = "glue"; > > #dma-cells = <2>; > > - #dma-channels = <30>; > > - #dma-requests = <256>; > > + dma-channels = <30>; > > + dma-requests = <256>; > > You could keep the old properties for compatibility and to apply > immediately. Indeed, that's a nice solution. Any preference from TI SoC maintainers? Best regards, Krzysztof
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220427 19:23]: > On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote: > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > > index f6ec85d58dd1..55ffb0813ded 100644 > > > --- a/arch/arm/boot/dts/am33xx.dtsi > > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > > @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 { > > > interrupts = <17>; > > > interrupt-names = "glue"; > > > #dma-cells = <2>; > > > - #dma-channels = <30>; > > > - #dma-requests = <256>; > > > + dma-channels = <30>; > > > + dma-requests = <256>; > > > > You could keep the old properties for compatibility and to apply > > immediately. > > Indeed, that's a nice solution. Any preference from TI SoC maintainers? Makes sense to me to avoid dependencies. Regards, Tony
On 28/04/2022 09:30, Tony Lindgren wrote: > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220427 19:23]: >> On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote: >>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >>>> index f6ec85d58dd1..55ffb0813ded 100644 >>>> --- a/arch/arm/boot/dts/am33xx.dtsi >>>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>>> @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 { >>>> interrupts = <17>; >>>> interrupt-names = "glue"; >>>> #dma-cells = <2>; >>>> - #dma-channels = <30>; >>>> - #dma-requests = <256>; >>>> + dma-channels = <30>; >>>> + dma-requests = <256>; >>> >>> You could keep the old properties for compatibility and to apply >>> immediately. >> >> Indeed, that's a nice solution. Any preference from TI SoC maintainers? > > Makes sense to me to avoid dependencies. Thanks. I will send a v3 today with such change. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index f6ec85d58dd1..55ffb0813ded 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 { interrupts = <17>; interrupt-names = "glue"; #dma-cells = <2>; - #dma-channels = <30>; - #dma-requests = <256>; + dma-channels = <30>; + dma-requests = <256>; }; };
The '#dma-channels' and '#dma-requests' properties were deprecated in favor of these defined by generic dma-common DT bindings. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/am33xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)