| Message ID | 20221101102947.27524-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | video: fbdev: omapfb: remove redundant variable checksum | expand |
On 11/1/22 11:29, Colin Ian King wrote: > Variable checksum is being used to accumulate values however > it is never read or used afterwards. It is redundant and can > be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> applied. Thanks! Helge > --- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > index cb63bc0e92ca..b33f62c5cb22 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > @@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext) > { > void __iomem *base = core->base; > u8 cur_addr; > - char checksum = 0; > const int retries = 1000; > u8 seg_ptr = ext / 2; > u8 edidbase = ((ext % 2) * 0x80); > @@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext) > } > > pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0); > - checksum += pedid[cur_addr]; > } > > return 0;
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c index cb63bc0e92ca..b33f62c5cb22 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c @@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext) { void __iomem *base = core->base; u8 cur_addr; - char checksum = 0; const int retries = 1000; u8 seg_ptr = ext / 2; u8 edidbase = ((ext % 2) * 0x80); @@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext) } pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0); - checksum += pedid[cur_addr]; } return 0;
Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 -- 1 file changed, 2 deletions(-)