| Message ID | 20221125144150.477290-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: omap: align LED node names with dtschema | expand |
Hi, On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote: > LP5523 LED controller does not take enable-gpios property: > > omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- The drivers uses it via devm_gpiod_get_optional() and the binding has this: grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml enable-gpio: maxItems: 1 description: | GPIO attached to the chip's enable pin -- Sebastian > arch/arm/boot/dts/omap3-n900.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index ba35cff5b01e..5e78dc990725 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -636,7 +636,6 @@ lp5523: lp5523@32 { > compatible = "national,lp5523"; > reg = <0x32>; > clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ > - enable-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ > > led@0 { > reg = <0>; > -- > 2.34.1 >
On 25/11/2022 18:36, Sebastian Reichel wrote: > Hi, > > On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote: >> LP5523 LED controller does not take enable-gpios property: >> >> omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > > The drivers uses it via devm_gpiod_get_optional() and the binding has this: > > grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > enable-gpio: > maxItems: 1 > description: | > GPIO attached to the chip's enable pin > > -- Sebastian Oh, thanks, I am pretty sure i was checking it but maybe I looked at wrong driver :(. I'll fix it in different way. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index ba35cff5b01e..5e78dc990725 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -636,7 +636,6 @@ lp5523: lp5523@32 { compatible = "national,lp5523"; reg = <0x32>; clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ - enable-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ led@0 { reg = <0>;
LP5523 LED controller does not take enable-gpios property: omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/omap3-n900.dts | 1 - 1 file changed, 1 deletion(-)