diff mbox series

[3/3] ARM: omap1: fix building gpio15xx

Message ID 20230109161636.512203-4-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series ARM: SoC fixes | expand

Commit Message

Arnd Bergmann Jan. 9, 2023, 4:16 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

In some randconfig builds, the asm/irq.h header is not included
in gpio15xx.c, so add an explicit include to avoid a build fialure:

In file included from arch/arm/mach-omap1/gpio15xx.c:15:
arch/arm/mach-omap1/irqs.h:99:34: error: 'NR_IRQS_LEGACY' undeclared here (not in a function)
   99 | #define IH2_BASE                (NR_IRQS_LEGACY + 32)
      |                                  ^~~~~~~~~~~~~~
arch/arm/mach-omap1/irqs.h:105:38: note: in expansion of macro 'IH2_BASE'
  105 | #define INT_MPUIO               (5 + IH2_BASE)
      |                                      ^~~~~~~~
arch/arm/mach-omap1/gpio15xx.c:28:27: note: in expansion of macro 'INT_MPUIO'
   28 |                 .start  = INT_MPUIO,
      |                           ^~~~~~~~~

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-omap1/gpio15xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Aaro Koskinen Jan. 10, 2023, 9:15 p.m. UTC | #1 
Hi,

On Mon, Jan 09, 2023 at 05:16:36PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> In some randconfig builds, the asm/irq.h header is not included
> in gpio15xx.c, so add an explicit include to avoid a build fialure:
> 
> In file included from arch/arm/mach-omap1/gpio15xx.c:15:
> arch/arm/mach-omap1/irqs.h:99:34: error: 'NR_IRQS_LEGACY' undeclared here (not in a function)
>    99 | #define IH2_BASE                (NR_IRQS_LEGACY + 32)
>       |                                  ^~~~~~~~~~~~~~
> arch/arm/mach-omap1/irqs.h:105:38: note: in expansion of macro 'IH2_BASE'
>   105 | #define INT_MPUIO               (5 + IH2_BASE)
>       |                                      ^~~~~~~~
> arch/arm/mach-omap1/gpio15xx.c:28:27: note: in expansion of macro 'INT_MPUIO'
>    28 |                 .start  = INT_MPUIO,
>       |                           ^~~~~~~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>

A.

> ---
>  arch/arm/mach-omap1/gpio15xx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap1/gpio15xx.c b/arch/arm/mach-omap1/gpio15xx.c
> index c675f11de99d..61fa26efd865 100644
> --- a/arch/arm/mach-omap1/gpio15xx.c
> +++ b/arch/arm/mach-omap1/gpio15xx.c
> @@ -11,6 +11,7 @@
>  #include <linux/gpio.h>
>  #include <linux/platform_data/gpio-omap.h>
>  #include <linux/soc/ti/omap1-soc.h>
> +#include <asm/irq.h>
>  
>  #include "irqs.h"
>  
> -- 
> 2.39.0
>
diff mbox series

Patch

diff --git a/arch/arm/mach-omap1/gpio15xx.c b/arch/arm/mach-omap1/gpio15xx.c
index c675f11de99d..61fa26efd865 100644
--- a/arch/arm/mach-omap1/gpio15xx.c
+++ b/arch/arm/mach-omap1/gpio15xx.c
@@ -11,6 +11,7 @@ 
 #include <linux/gpio.h>
 #include <linux/platform_data/gpio-omap.h>
 #include <linux/soc/ti/omap1-soc.h>
+#include <asm/irq.h>
 
 #include "irqs.h"