diff mbox series

regulator: tps65219: use IS_ERR() to detect an error pointer

Message ID 20230114184215.27806-1-rdunlap@infradead.org (mailing list archive)
State New
Headers show
Series regulator: tps65219: use IS_ERR() to detect an error pointer | expand

Commit Message

Randy Dunlap Jan. 14, 2023, 6:42 p.m. UTC
Fix pointer comparison to integer warning from gcc & sparse:

../drivers/regulator/tps65219-regulator.c:370:26: warning: ordered comparison of pointer with integer zero [-Wextra]
  370 |                 if (rdev < 0) {
      |                          ^

sparse warning:
drivers/regulator/tps65219-regulator.c:370:26: sparse: error: incompatible types for operation (<):
drivers/regulator/tps65219-regulator.c:370:26: sparse:    struct regulator_dev *[assigned] rdev
drivers/regulator/tps65219-regulator.c:370:26: sparse:    int

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jerome Neanne <j-neanne@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
 drivers/regulator/tps65219-regulator.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff -- a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -367,7 +367,7 @@  static int tps65219_regulator_probe(stru
 		irq_data[i].type = irq_type;
 		tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev);
-		if (rdev < 0) {
+		if (IS_ERR(rdev)) {
 			dev_err(tps->dev, "Failed to get rdev for %s\n",
 			return -EINVAL;