| Message ID | 20230209025525.148872-2-colin.foster@in-advantage.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add support for Phytec PCM-049 and PCM-959 | expand |
On Wed, Feb 08, 2023 at 06:55:24PM -0800, Colin Foster wrote: > Add documentation for additional OMAP SOMs and development platforms, > provided by Phytec as the PCM-049 SOM and the PCM-959 development kit. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > v2->v3 > * Add Krzysztof Acked > > v1->v2 > * New patch > > --- > Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt > index fa8b31660cad..0a28215dfa12 100644 > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > @@ -131,6 +131,9 @@ Boards (incomplete list of examples): > - OMAP4 PandaBoard : Low cost community board > compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4" > > +- OMAP4 PCM-959 : Commercial dev kit with PCM-049 SOM > + compatible = "phytec,pcm959", "phytec,pcm049", "ti,omap4460", "ti,omap4430", "ti,omap4"; OMAP maintainers, if no one is going to convert all of omap.txt over to schema, can we at least start an empty schema and add to it instead of here... Rob
* Rob Herring <robh@kernel.org> [230209 19:35]: > On Wed, Feb 08, 2023 at 06:55:24PM -0800, Colin Foster wrote: > > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > > @@ -131,6 +131,9 @@ Boards (incomplete list of examples): > > - OMAP4 PandaBoard : Low cost community board > > compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4" > > > > +- OMAP4 PCM-959 : Commercial dev kit with PCM-049 SOM > > + compatible = "phytec,pcm959", "phytec,pcm049", "ti,omap4460", "ti,omap4430", "ti,omap4"; Do you have both "ti,omap4460" and "ti,omap4430" SoCs variants for these boards? If not just drop the SoC variant not in use. If you do have, please mention it in the commit message. > OMAP maintainers, if no one is going to convert all of omap.txt over to > schema, can we at least start an empty schema and add to it instead of > here... That sounds like a good plan to me as it allows moving one device at a time. Colin, care to add the initial yaml binding file with your board? Regards, Tony
Hi Tony, On Wed, Feb 15, 2023 at 09:14:43AM +0200, Tony Lindgren wrote: > * Rob Herring <robh@kernel.org> [230209 19:35]: > > On Wed, Feb 08, 2023 at 06:55:24PM -0800, Colin Foster wrote: > > > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > > > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > > > @@ -131,6 +131,9 @@ Boards (incomplete list of examples): > > > - OMAP4 PandaBoard : Low cost community board > > > compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4" > > > > > > +- OMAP4 PCM-959 : Commercial dev kit with PCM-049 SOM > > > + compatible = "phytec,pcm959", "phytec,pcm049", "ti,omap4460", "ti,omap4430", "ti,omap4"; > > Do you have both "ti,omap4460" and "ti,omap4430" SoCs variants for > these boards? If not just drop the SoC variant not in use. If you do have, > please mention it in the commit message. I don't, no. It might not be an issue anymore, but I remember there was some reason I thought it had to be there. That was back when I was struggling to get anything booting, so it might have been a false positive. I'll remove it, or at the very least explain why it needs to be there in the next version. > > > OMAP maintainers, if no one is going to convert all of omap.txt over to > > schema, can we at least start an empty schema and add to it instead of > > here... > > That sounds like a good plan to me as it allows moving one device at a > time. > > Colin, care to add the initial yaml binding file with your board? I'll give it a go. To be clear, this would be Documentation/devicetree/bindings/arm/omap.yaml and it would include my device? I'm taking Documentation/devicetree/bindings/arm/sunxi.yaml as inspiration (for no reason other than it was the first one that I came across that seemed to solve this same issue) > > Regards, > > Tony
* Colin Foster <colin.foster@in-advantage.com> [230215 16:46]: > On Wed, Feb 15, 2023 at 09:14:43AM +0200, Tony Lindgren wrote: > > * Rob Herring <robh@kernel.org> [230209 19:35]: > > > OMAP maintainers, if no one is going to convert all of omap.txt over to > > > schema, can we at least start an empty schema and add to it instead of > > > here... > > > > That sounds like a good plan to me as it allows moving one device at a > > time. > > > > Colin, care to add the initial yaml binding file with your board? > > I'll give it a go. To be clear, this would be > Documentation/devicetree/bindings/arm/omap.yaml and it would > include my device? I'm taking > Documentation/devicetree/bindings/arm/sunxi.yaml as inspiration (for no > reason other than it was the first one that I came across that seemed to > solve this same issue) Yes just something minimal to start with. Thanks, Tony
diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt index fa8b31660cad..0a28215dfa12 100644 --- a/Documentation/devicetree/bindings/arm/omap/omap.txt +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt @@ -131,6 +131,9 @@ Boards (incomplete list of examples): - OMAP4 PandaBoard : Low cost community board compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4" +- OMAP4 PCM-959 : Commercial dev kit with PCM-049 SOM + compatible = "phytec,pcm959", "phytec,pcm049", "ti,omap4460", "ti,omap4430", "ti,omap4"; + - OMAP4 DuoVero with Parlor : Commercial expansion board with daughter board compatible = "gumstix,omap4-duovero-parlor", "gumstix,omap4-duovero", "ti,omap4430", "ti,omap4";