From patchwork Mon Jun 12 12:40:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13276450 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A78C7EE25 for ; Mon, 12 Jun 2023 12:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbjFLMkh (ORCPT ); Mon, 12 Jun 2023 08:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233493AbjFLMkf (ORCPT ); Mon, 12 Jun 2023 08:40:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC0B3E4E; Mon, 12 Jun 2023 05:40:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B3E361DDA; Mon, 12 Jun 2023 12:40:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F0C6C4339B; Mon, 12 Jun 2023 12:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686573633; bh=A6bGNMNMde5NDVbabkyRI7fOdxDo5P2/Hp6ldKTKw+g=; h=From:To:Cc:Subject:Date:From; b=EvyNJE8QHXsqnkhPDN0RwUjIaTgp50gmyRxBVXf78l7CffpCTYKedAHHytcqiEFsh j3J8OpAlJ0rqweuexIStvLasjC61KfEqCivJV1deUQxWH4d6vU9FfMQsGotkM6WeXq GaGy4eUmWQHvccN9egFravTdCPWpgX9tkH6oFHtwu6E7PPvwmvq8dmCqzYjNAygXi3 ze5uxupfm2+jOLyzwZTA7+0DpK4tyVFlFQ5x9GsjScUlYS7l+qpd3u3ILrU3xvzkB9 ZBh0v9R1Q/ZJVaSIYyHhMPOKYU6omGdWArmq+VTOsymKV0iSvUgOxcJipCekMPhTNS 2VoZ74c/fV6pQ== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Grygorii Strashko , linux-omap@vger.kernel.org, Vignesh Raghavendra , Nishanth Menon , Tero Kristo , Arnd Bergmann , Randy Dunlap , Mao Wenan , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] net: ethernet: ti-cpsw: select CONFIG_GENERIC_ALLOCATOR Date: Mon, 12 Jun 2023 14:40:04 +0200 Message-Id: <20230612124024.520720-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Arnd Bergmann The dependency was lost for both cpsw and davinci-emac, but only added back for the emac driver, so a cpsw-only build can still fail: x86_64-linux-ld: vmlinux.o: in function `cpdma_desc_pool_destroy': davinci_cpdma.c:(.text+0xd9fb97): undefined reference to `gen_pool_size' x86_64-linux-ld: davinci_cpdma.c:(.text+0xd9fba8): undefined reference to `gen_pool_avail' x86_64-linux-ld: vmlinux.o: in function `cpdma_desc_pool_create': davinci_cpdma.c:(.text+0xd9fd21): undefined reference to `devm_gen_pool_create' x86_64-linux-ld: davinci_cpdma.c:(.text+0xd9fe15): undefined reference to `gen_pool_add_owner' x86_64-linux-ld: vmlinux.o: in function `__cpdma_chan_free': davinci_cpdma.c:(.text+0xd9ffde): undefined reference to `gen_pool_free_owner' x86_64-linux-ld: vmlinux.o: in function `cpdma_chan_submit_si': davinci_cpdma.c:(.text+0xda039e): undefined reference to `gen_pool_alloc_algo_owner' x86_64-linux-ld: davinci_cpdma.c:(.text+0xda064f): undefined reference to `gen_pool_free_owner' x86_64-linux-ld: vmlinux.o: in function `cpdma_check_free_tx_desc': Fixes: b2ef81dcdf383 ("net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC") Fixes: 99f6297182729 ("net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index fce06663e1e11..18b2160a96260 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -51,6 +51,7 @@ config TI_CPSW tristate "TI CPSW Switch Support" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on TI_CPTS || !TI_CPTS + select GENERIC_ALLOCATOR select TI_DAVINCI_MDIO select MFD_SYSCON select PAGE_POOL @@ -67,6 +68,7 @@ config TI_CPSW_SWITCHDEV depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on NET_SWITCHDEV depends on TI_CPTS || !TI_CPTS + select GENERIC_ALLOCATOR select PAGE_POOL select TI_DAVINCI_MDIO select MFD_SYSCON