| Message ID | 20230727091446.859984-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] gpio: Remove redundant dev_err_probe() | expand |
On Thu, Jul 27, 2023 at 05:14:46PM +0800, Ruan Jinjie wrote: > There is no need to call the dev_err_probe() function directly to print > a custom message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. Please, split on per-driver basis. The code wise it's okay, you may add to each patch in v2 Reviewed-by: Andy Shevchenko <andy@kernel.org> > drivers/gpio/gpio-davinci.c | 2 +- > drivers/gpio/gpio-omap.c | 2 +-
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index fff510d86e31..8db5717bdabe 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -236,7 +236,7 @@ static int davinci_gpio_probe(struct platform_device *pdev) for (i = 0; i < nirq; i++) { chips->irqs[i] = platform_get_irq(pdev, i); if (chips->irqs[i] < 0) - return dev_err_probe(dev, chips->irqs[i], "IRQ not populated\n"); + return chips->irqs[i]; } chips->chip.label = dev_name(dev); diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 2b78fde74e30..21c8cfedfd64 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1415,7 +1415,7 @@ static int omap_gpio_probe(struct platform_device *pdev) if (bank->irq <= 0) { if (!bank->irq) bank->irq = -ENXIO; - return dev_err_probe(dev, bank->irq, "can't get irq resource\n"); + return bank->irq; } bank->chip.parent = dev;
There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/gpio/gpio-davinci.c | 2 +- drivers/gpio/gpio-omap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)