| Message ID | 20240108183302.255055-2-afd@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Device tree support for Imagination Series5 GPU | expand |
Andrew Davis <afd@ti.com> writes: Hello Andrew, > Signed-off-by: Andrew Davis <afd@ti.com> > --- I think this deserves a commit message with the rationale for the rename. Because kept an eye to the previous version, I know the reason and agree with the change. Also, if remember correctly this was suggested by Maxime? After a adding a commit message and Suggested-by tag: Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Andrew, On Mon, 2024-01-08 at 12:32 -0600, Andrew Davis wrote: > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- > MAINTAINERS | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%) > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > similarity index 91% > rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml > rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index a13298f1a1827..03a8308b41ae7 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -2,10 +2,10 @@ > # Copyright (c) 2023 Imagination Technologies Ltd. > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# > +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Imagination Technologies PowerVR and IMG GPU > +title: Imagination Technologies PowerVR Rogue and IMG GPUs All the GPUs that will appear in this file will be Rogues, so for me it would be more natural for 'Rogue' to come after 'IMG'. Can you change the title to: Imagination Technologies PowerVR and IMG Rogue GPUs With that changed and Javier's suggestions addressed: Reviewed-by: Frank Binns <frank.binns@imgtec.com> > > maintainers: > - Frank Binns <frank.binns@imgtec.com> > diff --git a/MAINTAINERS b/MAINTAINERS > index fa67e2624723f..5b205795da04e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10461,7 +10461,7 @@ M: Donald Robson <donald.robson@imgtec.com> > M: Matt Coster <matt.coster@imgtec.com> > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/gpu/img,powervr.yaml > +F: Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > F: Documentation/gpu/imagination/ > F: drivers/gpu/drm/imagination/ > F: include/uapi/drm/pvr_drm.h
On 08/01/2024 19:32, Andrew Davis wrote: > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- > MAINTAINERS | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) If you are renaming it, why not renaming to match compatible as we usually expect? Best regards, Krzysztof
On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote: > On 08/01/2024 19:32, Andrew Davis wrote: >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- >> MAINTAINERS | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > If you are renaming it, why not renaming to match compatible as we > usually expect? > There are (or will be) multiple compatible strings described in this file, naming the file after just one would not fully convey the content of the file. This generic style naming seems common already for bindings with multiple compatibles. Andrew > Best regards, > Krzysztof >
On 09/01/2024 17:14, Andrew Davis wrote: > On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote: >> On 08/01/2024 19:32, Andrew Davis wrote: >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- >>> MAINTAINERS | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> If you are renaming it, why not renaming to match compatible as we >> usually expect? >> > > There are (or will be) multiple compatible strings described in this > file, naming the file after just one would not fully convey the content > of the file. This generic style naming seems common already for bindings > with multiple compatibles. I saw only one compatible used as fallback. Where are more? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml similarity index 91% rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml index a13298f1a1827..03a8308b41ae7 100644 --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml @@ -2,10 +2,10 @@ # Copyright (c) 2023 Imagination Technologies Ltd. %YAML 1.2 --- -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Imagination Technologies PowerVR and IMG GPU +title: Imagination Technologies PowerVR Rogue and IMG GPUs maintainers: - Frank Binns <frank.binns@imgtec.com> diff --git a/MAINTAINERS b/MAINTAINERS index fa67e2624723f..5b205795da04e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10461,7 +10461,7 @@ M: Donald Robson <donald.robson@imgtec.com> M: Matt Coster <matt.coster@imgtec.com> S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc -F: Documentation/devicetree/bindings/gpu/img,powervr.yaml +F: Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml F: Documentation/gpu/imagination/ F: drivers/gpu/drm/imagination/ F: include/uapi/drm/pvr_drm.h
Signed-off-by: Andrew Davis <afd@ti.com> --- .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- MAINTAINERS | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%)