| Message ID | 20241220223523.2125278-1-jm@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: ti: am437x-l4: remove autoidle for UART | expand |
On Fri, Dec 20, 2024 at 04:35:23PM -0600, Judith Mendez wrote: > According to the TRM [0] in 21.5.1.42 UART_SYSC Register, > the autoidle bit should not be set for UART, so remove the > appropriate SYSC_OMAP2_AUTOIDLE flag. > > [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf > Signed-off-by: Judith Mendez <jm@ti.com> > --- > arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > index 824b9415ebbe9..fd4634f8c6293 100644 > --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi > @@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */ > <0x9058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > @@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */ > <0x22058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > @@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */ > <0x24058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > @@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */ > <0xa6058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > @@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */ > <0xa8058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > @@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */ > <0xaa058 0x4>; > reg-names = "rev", "sysc", "syss"; > ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > - SYSC_OMAP2_SOFTRESET | > - SYSC_OMAP2_AUTOIDLE)>; > + SYSC_OMAP2_SOFTRESET)>; > ti,sysc-sidle = <SYSC_IDLE_FORCE>, > <SYSC_IDLE_NO>, > <SYSC_IDLE_SMART>, > -- > 2.47.1 > Looks good to me. Reviewed-by: Sukrut Bellary <sbellary@baylibre.com>
diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi index 824b9415ebbe9..fd4634f8c6293 100644 --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi @@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */ <0x9058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>, @@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */ <0x22058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>, @@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */ <0x24058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>, @@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */ <0xa6058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>, @@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */ <0xa8058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>, @@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */ <0xaa058 0x4>; reg-names = "rev", "sysc", "syss"; ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | - SYSC_OMAP2_SOFTRESET | - SYSC_OMAP2_AUTOIDLE)>; + SYSC_OMAP2_SOFTRESET)>; ti,sysc-sidle = <SYSC_IDLE_FORCE>, <SYSC_IDLE_NO>, <SYSC_IDLE_SMART>,
According to the TRM [0] in 21.5.1.42 UART_SYSC Register, the autoidle bit should not be set for UART, so remove the appropriate SYSC_OMAP2_AUTOIDLE flag. [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf Signed-off-by: Judith Mendez <jm@ti.com> --- arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)