| Message ID | 20250103230446.197597-2-s-ramamoorthy@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add TI TPS65215 PMIC Regulator Support | expand |
On Fri, Jan 03, 2025 at 05:04:40PM -0600, Shree Ramamoorthy wrote: > TPS65215 is a Power Management IC with 3 Buck regulators and 2 LDOs. > > TPS65215 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs. The > remaining features for both devices are the same. > > Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/regulator/ti,tps65219.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > index 78e64521d401..ba5f6fcf5219 100644 > --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: TI tps65219 Power Management Integrated Circuit regulators > +title: TI TPS65215/TPS65219 Power Management Integrated Circuit > > maintainers: > - Jerome Neanne <jerome.neanne@baylibre.com> > @@ -12,10 +12,17 @@ maintainers: > description: | > Regulator nodes should be named to buck<number> and ldo<number>. > > + TI TPS65219 is a Power Management IC with 3 Buck regulators, 4 Low > + Drop-out Regulators (LDOs), 1 GPIO, 2 GPOs, and power-button. > + > + TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low > + Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button. Then you need allOf:if:then: which will disallow :false two LDOs and their supplies. > + > properties: > compatible: > enum: > - ti,tps65219 > + - ti,tps65215 Keep things ordered, don't add whatever you add to the end of the lists. Best regards, Krzysztof
Hi, On 1/4/2025 4:13 AM, Krzysztof Kozlowski wrote: > On Fri, Jan 03, 2025 at 05:04:40PM -0600, Shree Ramamoorthy wrote: >> TPS65215 is a Power Management IC with 3 Buck regulators and 2 LDOs. >> >> TPS65215 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs. The >> remaining features for both devices are the same. >> >> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> .../devicetree/bindings/regulator/ti,tps65219.yaml | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml >> index 78e64521d401..ba5f6fcf5219 100644 >> --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml >> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml >> @@ -4,7 +4,7 @@ >> $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: TI tps65219 Power Management Integrated Circuit regulators >> +title: TI TPS65215/TPS65219 Power Management Integrated Circuit >> >> maintainers: >> - Jerome Neanne <jerome.neanne@baylibre.com> >> @@ -12,10 +12,17 @@ maintainers: >> description: | >> Regulator nodes should be named to buck<number> and ldo<number>. >> >> + TI TPS65219 is a Power Management IC with 3 Buck regulators, 4 Low >> + Drop-out Regulators (LDOs), 1 GPIO, 2 GPOs, and power-button. >> + >> + TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low >> + Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button. > Then you need allOf:if:then: which will disallow :false two LDOs and > their supplies. Thank you for your feedback! I did not know about this & will add it in. >> + >> properties: >> compatible: >> enum: >> - ti,tps65219 >> + - ti,tps65215 > Keep things ordered, don't add whatever you add to the end of the lists. > > Best regards, > Krzysztof Noted, will make this change for the next version. Thanks!
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml index 78e64521d401..ba5f6fcf5219 100644 --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TI tps65219 Power Management Integrated Circuit regulators +title: TI TPS65215/TPS65219 Power Management Integrated Circuit maintainers: - Jerome Neanne <jerome.neanne@baylibre.com> @@ -12,10 +12,17 @@ maintainers: description: | Regulator nodes should be named to buck<number> and ldo<number>. + TI TPS65219 is a Power Management IC with 3 Buck regulators, 4 Low + Drop-out Regulators (LDOs), 1 GPIO, 2 GPOs, and power-button. + + TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low + Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button. + properties: compatible: enum: - ti,tps65219 + - ti,tps65215 reg: maxItems: 1