| Message ID | 20250109214219.123767-1-alexander.sverdlin@siemens.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE | expand |
On Thu, Jan 09, 2025 at 10:42:13PM +0100, A. Sverdlin wrote: > From: Alexander Sverdlin <alexander.sverdlin@siemens.com> > > In all 3 cases (cpsw, cpsw-new, am65-cpsw) ALE is being configured in > VLAN-aware mode, while the comment states the opposite. Seems to be a typo > copy-pasted from one driver to another. Fix the commend which has been > puzzling some people (including me) for at least a decade. > > Link: https://lore.kernel.org/linux-arm-kernel/4699400.vD3TdgH1nR@localhost/ > Link: https://lore.kernel.org/netdev/0106ce78-c83f-4552-a234-1bf7a33f1ed1@kernel.org/ > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 9 Jan 2025 22:42:13 +0100 you wrote: > From: Alexander Sverdlin <alexander.sverdlin@siemens.com> > > In all 3 cases (cpsw, cpsw-new, am65-cpsw) ALE is being configured in > VLAN-aware mode, while the comment states the opposite. Seems to be a typo > copy-pasted from one driver to another. Fix the commend which has been > puzzling some people (including me) for at least a decade. > > [...] Here is the summary with links: - [net-next] net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE https://git.kernel.org/netdev/net-next/c/460b52835e60 You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index 5465bf872734..dcb6662b473d 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -762,7 +762,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) ALE_DEFAULT_THREAD_ID, 0); cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_DEFAULT_THREAD_ENABLE, 1); - /* switch to vlan unaware mode */ + /* switch to vlan aware mode */ cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 1); cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_PORT_STATE, ALE_PORT_STATE_FORWARD); diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 1e290ee8edfd..0cb6fa6e5b7d 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -686,7 +686,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv) soft_reset("cpsw", &cpsw->regs->soft_reset); cpsw_ale_start(cpsw->ale); - /* switch to vlan unaware mode */ + /* switch to vlan aware mode */ cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, CPSW_ALE_VLAN_AWARE); control_reg = readl(&cpsw->regs->control); diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c index be4d90c1cbe7..cec0a90659d9 100644 --- a/drivers/net/ethernet/ti/cpsw_new.c +++ b/drivers/net/ethernet/ti/cpsw_new.c @@ -554,7 +554,7 @@ static void cpsw_init_host_port(struct cpsw_priv *priv) soft_reset("cpsw", &cpsw->regs->soft_reset); cpsw_ale_start(cpsw->ale); - /* switch to vlan unaware mode */ + /* switch to vlan aware mode */ cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, CPSW_ALE_VLAN_AWARE); control_reg = readl(&cpsw->regs->control);