| Message ID | 20250312121712.1168007-1-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE_PM for eMMC/SD | expand |
On 12/03/25 14:17, Ulf Hansson wrote: > We have received reports about cards can become corrupt related to the > aggressive PM support. Let's make a partial revert of the change that > enabled the feature. > > Reported-by: David Owens <daowens01@gmail.com> > Reported-by: Romain Naour <romain.naour@smile.fr> > Reported-by: Robert Nelson <robertcnelson@gmail.com> > Tested-by: Robert Nelson <robertcnelson@gmail.com> > Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM") > Cc: stable@vger.kernel.org > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-omap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index 54d795205fb4..26a9a8b5682a 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) > /* R1B responses is required to properly manage HW busy detection. */ > mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > - /* Allow card power off and runtime PM for eMMC/SD card devices */ > - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; > + /* Enable SDIO card power off. */ > + mmc->caps |= MMC_CAP_POWER_OFF_CARD; > > ret = sdhci_setup_host(host); > if (ret)
On Wed, Mar 12, 2025 at 7:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > We have received reports about cards can become corrupt related to the > aggressive PM support. Let's make a partial revert of the change that > enabled the feature. > > Reported-by: David Owens <daowens01@gmail.com> > Reported-by: Romain Naour <romain.naour@smile.fr> > Reported-by: Robert Nelson <robertcnelson@gmail.com> > Tested-by: Robert Nelson <robertcnelson@gmail.com> > Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM") > Cc: stable@vger.kernel.org > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/mmc/host/sdhci-omap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index 54d795205fb4..26a9a8b5682a 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) > /* R1B responses is required to properly manage HW busy detection. */ > mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > - /* Allow card power off and runtime PM for eMMC/SD card devices */ > - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; > + /* Enable SDIO card power off. */ > + mmc->caps |= MMC_CAP_POWER_OFF_CARD; > > ret = sdhci_setup_host(host); > if (ret) > -- > 2.43.0 > Thanks Ulf, i also have this exact revert running on the target in our ci farm, i think we should be good. But I'll validate it in 4 weeks! Regards,
On Sun, 16 Mar 2025 at 21:54, Robert Nelson <robertcnelson@gmail.com> wrote: > > On Wed, Mar 12, 2025 at 7:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > We have received reports about cards can become corrupt related to the > > aggressive PM support. Let's make a partial revert of the change that > > enabled the feature. > > > > Reported-by: David Owens <daowens01@gmail.com> > > Reported-by: Romain Naour <romain.naour@smile.fr> > > Reported-by: Robert Nelson <robertcnelson@gmail.com> > > Tested-by: Robert Nelson <robertcnelson@gmail.com> > > Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM") > > Cc: stable@vger.kernel.org > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > --- > > drivers/mmc/host/sdhci-omap.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > > index 54d795205fb4..26a9a8b5682a 100644 > > --- a/drivers/mmc/host/sdhci-omap.c > > +++ b/drivers/mmc/host/sdhci-omap.c > > @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) > > /* R1B responses is required to properly manage HW busy detection. */ > > mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > > > - /* Allow card power off and runtime PM for eMMC/SD card devices */ > > - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; > > + /* Enable SDIO card power off. */ > > + mmc->caps |= MMC_CAP_POWER_OFF_CARD; > > > > ret = sdhci_setup_host(host); > > if (ret) > > -- > > 2.43.0 > > > > Thanks Ulf, i also have this exact revert running on the target in our > ci farm, i think we should be good. But I'll validate it in 4 weeks! > > Regards, > > -- > Robert Nelson > https://rcn-ee.com/ Thanks Robert for helping out! In the meantime I decided to queue this up for next, to allow it to get more testing in linux-next. Kind regards Uffe
* Ulf Hansson <ulf.hansson@linaro.org> [250317 10:51]: > On Sun, 16 Mar 2025 at 21:54, Robert Nelson <robertcnelson@gmail.com> wrote: > > > > On Wed, Mar 12, 2025 at 7:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > We have received reports about cards can become corrupt related to the > > > aggressive PM support. Let's make a partial revert of the change that > > > enabled the feature. > > > > > > Reported-by: David Owens <daowens01@gmail.com> > > > Reported-by: Romain Naour <romain.naour@smile.fr> > > > Reported-by: Robert Nelson <robertcnelson@gmail.com> > > > Tested-by: Robert Nelson <robertcnelson@gmail.com> > > > Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > > --- > > > drivers/mmc/host/sdhci-omap.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > > > index 54d795205fb4..26a9a8b5682a 100644 > > > --- a/drivers/mmc/host/sdhci-omap.c > > > +++ b/drivers/mmc/host/sdhci-omap.c > > > @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) > > > /* R1B responses is required to properly manage HW busy detection. */ > > > mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > > > > > - /* Allow card power off and runtime PM for eMMC/SD card devices */ > > > - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; > > > + /* Enable SDIO card power off. */ > > > + mmc->caps |= MMC_CAP_POWER_OFF_CARD; > > > > > > ret = sdhci_setup_host(host); > > > if (ret) > > > -- > > > 2.43.0 > > > > > > > Thanks Ulf, i also have this exact revert running on the target in our > > ci farm, i think we should be good. But I'll validate it in 4 weeks! > > > > Regards, > > > > -- > > Robert Nelson > > https://rcn-ee.com/ > > Thanks Robert for helping out! > > In the meantime I decided to queue this up for next, to allow it to > get more testing in linux-next. Thanks looks good to me too. Regards, Tony
On Wed, 19 Mar 2025 at 04:59, Tony Lindgren <tony@atomide.com> wrote: > > * Ulf Hansson <ulf.hansson@linaro.org> [250317 10:51]: > > On Sun, 16 Mar 2025 at 21:54, Robert Nelson <robertcnelson@gmail.com> wrote: > > > > > > On Wed, Mar 12, 2025 at 7:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > > > We have received reports about cards can become corrupt related to the > > > > aggressive PM support. Let's make a partial revert of the change that > > > > enabled the feature. > > > > > > > > Reported-by: David Owens <daowens01@gmail.com> > > > > Reported-by: Romain Naour <romain.naour@smile.fr> > > > > Reported-by: Robert Nelson <robertcnelson@gmail.com> > > > > Tested-by: Robert Nelson <robertcnelson@gmail.com> > > > > Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > > > --- > > > > drivers/mmc/host/sdhci-omap.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > > > > index 54d795205fb4..26a9a8b5682a 100644 > > > > --- a/drivers/mmc/host/sdhci-omap.c > > > > +++ b/drivers/mmc/host/sdhci-omap.c > > > > @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) > > > > /* R1B responses is required to properly manage HW busy detection. */ > > > > mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > > > > > > > - /* Allow card power off and runtime PM for eMMC/SD card devices */ > > > > - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; > > > > + /* Enable SDIO card power off. */ > > > > + mmc->caps |= MMC_CAP_POWER_OFF_CARD; > > > > > > > > ret = sdhci_setup_host(host); > > > > if (ret) > > > > -- > > > > 2.43.0 > > > > > > > > > > Thanks Ulf, i also have this exact revert running on the target in our > > > ci farm, i think we should be good. But I'll validate it in 4 weeks! > > > > > > Regards, > > > > > > -- > > > Robert Nelson > > > https://rcn-ee.com/ > > > > Thanks Robert for helping out! > > > > In the meantime I decided to queue this up for next, to allow it to > > get more testing in linux-next. > > Thanks looks good to me too. > > Regards, > > Tony Thanks, I have added your Reviewed-by tag too. Kind regards Uffe
diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 54d795205fb4..26a9a8b5682a 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev) /* R1B responses is required to properly manage HW busy detection. */ mmc->caps |= MMC_CAP_NEED_RSP_BUSY; - /* Allow card power off and runtime PM for eMMC/SD card devices */ - mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM; + /* Enable SDIO card power off. */ + mmc->caps |= MMC_CAP_POWER_OFF_CARD; ret = sdhci_setup_host(host); if (ret)