| Message ID | 2942784.trumtc2GjZ@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Arnd Bergmann <arnd@arndb.de> [130531 09:05]: > The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" > has caused a new warning for omap1_defconfig: > > drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] > static void omap_gpio_init_context(struct gpio_bank *p) {} > ^ > > The solution is to mark the stub function as 'static inline' so > it gets left out of the build when unused. Acked-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index d3f7d2d..e5fba65 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) > #else > #define omap_gpio_runtime_suspend NULL > #define omap_gpio_runtime_resume NULL > -static void omap_gpio_init_context(struct gpio_bank *p) {} > +static inline void omap_gpio_init_context(struct gpio_bank *p) {} > #endif > > static const struct dev_pm_ops gpio_pm_ops = { > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 31 May 2013 11:59 AM, Arnd Bergmann wrote: > The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" > has caused a new warning for omap1_defconfig: > > drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] > static void omap_gpio_init_context(struct gpio_bank *p) {} > ^ > > The solution is to mark the stub function as 'static inline' so > it gets left out of the build when unused. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 31, 2013 at 5:59 PM, Arnd Bergmann <arnd@arndb.de> wrote: > The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" > has caused a new warning for omap1_defconfig: > > drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] > static void omap_gpio_init_context(struct gpio_bank *p) {} > ^ > > The solution is to mark the stub function as 'static inline' so > it gets left out of the build when unused. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied with Tony's and Santosh's ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index d3f7d2d..e5fba65 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank) #else #define omap_gpio_runtime_suspend NULL #define omap_gpio_runtime_resume NULL -static void omap_gpio_init_context(struct gpio_bank *p) {} +static inline void omap_gpio_init_context(struct gpio_bank *p) {} #endif static const struct dev_pm_ops gpio_pm_ops = {
The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" has caused a new warning for omap1_defconfig: drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] static void omap_gpio_init_context(struct gpio_bank *p) {} ^ The solution is to mark the stub function as 'static inline' so it gets left out of the build when unused. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html