| Message ID | 4351524.MQWtq16mqg@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: > > > > I don't know what to do here, there is no point to build any of the files > > in mach-mvebu if no SoCs are selected. So either we force to have at least > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if > > no SoCs are selected. > > The latter does not work, because that would introduce a circular > dependency in Kconfig. > > I suppose rearranging the mvebu Makefile like this would do. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> This error is still present in arm-soc. We're getting close to the next merge window, so either something needs to be dropped from arm-soc, or this needs to get fixed. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote: > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: > > > > > > I don't know what to do here, there is no point to build any of the files > > > in mach-mvebu if no SoCs are selected. So either we force to have at least > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if > > > no SoCs are selected. > > > > The latter does not work, because that would introduce a circular > > dependency in Kconfig. > > > > I suppose rearranging the mvebu Makefile like this would do. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > This error is still present in arm-soc. We're getting close to the next > merge window, so either something needs to be dropped from arm-soc, or > this needs to get fixed. > Can you point me to where can I get the config your building with? Thanks,
On Thu, Feb 14, 2013 at 08:03:08AM -0300, Ezequiel Garcia wrote: > On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote: > > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: > > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: > > > > > > > > I don't know what to do here, there is no point to build any of the files > > > > in mach-mvebu if no SoCs are selected. So either we force to have at least > > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if > > > > no SoCs are selected. > > > > > > The latter does not work, because that would introduce a circular > > > dependency in Kconfig. > > > > > > I suppose rearranging the mvebu Makefile like this would do. > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > This error is still present in arm-soc. We're getting close to the next > > merge window, so either something needs to be dropped from arm-soc, or > > this needs to get fixed. > > > > Can you point me to where can I get the config your building with? It's all publically available via my website. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 14 February 2013, Ezequiel Garcia wrote: > On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote: > > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: > > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: > > > > > > > > I don't know what to do here, there is no point to build any of the files > > > > in mach-mvebu if no SoCs are selected. So either we force to have at least > > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if > > > > no SoCs are selected. > > > > > > The latter does not work, because that would introduce a circular > > > dependency in Kconfig. > > > > > > I suppose rearranging the mvebu Makefile like this would do. > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > This error is still present in arm-soc. We're getting close to the next > > merge window, so either something needs to be dropped from arm-soc, or > > this needs to get fixed. > > > > Can you point me to where can I get the config your building with? It is essentially any configuration that turns on ARCH_MVEBU but not MACH_ARMADA_370 or MACH_ARMADA_XP. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote: > On Thu, Feb 14, 2013 at 08:03:08AM -0300, Ezequiel Garcia wrote: > > On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote: > > > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote: > > > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: > > > > > > > > > > I don't know what to do here, there is no point to build any of the files > > > > > in mach-mvebu if no SoCs are selected. So either we force to have at least > > > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if > > > > > no SoCs are selected. > > > > > > > > The latter does not work, because that would introduce a circular > > > > dependency in Kconfig. > > > > > > > > I suppose rearranging the mvebu Makefile like this would do. > > > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > > > This error is still present in arm-soc. We're getting close to the next > > > merge window, so either something needs to be dropped from arm-soc, or > > > this needs to get fixed. > > > > > > > Can you point me to where can I get the config your building with? > > It's all publically available via my website. I'm kind of new around here, and I have no clue where that may be. I hope you don't mind helping me this time. Thanks,
On Thursday 14 February 2013, Ezequiel Garcia wrote: > On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote: > > > > It's all publically available via my website. > > I'm kind of new around here, and I have no clue where that may be. > > I hope you don't mind helping me this time. Please have a look at http://www.arm.linux.org.uk/developer/build/ Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, On Thu, Feb 14, 2013 at 11:27:07AM +0000, Arnd Bergmann wrote: > On Thursday 14 February 2013, Ezequiel Garcia wrote: > > On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote: > > > > > > It's all publically available via my website. > > > > I'm kind of new around here, and I have no clue where that may be. > > > > I hope you don't mind helping me this time. > > > Please have a look at http://www.arm.linux.org.uk/developer/build/ Okey. FYI, using the random config file for OMAP4430 and also with a manual config that chooses ARCH_MVEBU but doesn't choose MACH_ARMADA_XP or MACH_ARMADA_370, this make error is *gone* after applying your patch: arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus': :(.init.text+0x74): undefined reference to `coherency_get_cpu_count' :(.init.text+0xb8): undefined reference to `armada_mpic_send_doorbell' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus': :(.init.text+0x250): undefined reference to `set_cpu_coherent' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary': :(.cpuinit.text+0x10): undefined reference to `armada_xp_boot_cpu' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init': :(.cpuinit.text+0x2c): undefined reference to `armada_xp_mpic_smp_cpu_init' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup': :(.cpuinit.text+0x40): undefined reference to `ll_set_cpu_coherent' Now, using the random config there's a new error, unrelated to the previous one: ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined! ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined! ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined! ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined! Regards,
On 02/08/2013 02:33 PM, Arnd Bergmann wrote: > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote: >> >> I don't know what to do here, there is no point to build any of the files >> in mach-mvebu if no SoCs are selected. So either we force to have at least >> one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if >> no SoCs are selected. > > The latter does not work, because that would introduce a circular > dependency in Kconfig. > > I suppose rearranging the mvebu Makefile like this would do. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile > index 99df4df..c0434dc 100644 > --- a/arch/arm/mach-mvebu/Makefile > +++ b/arch/arm/mach-mvebu/Makefile > @@ -1,9 +1,15 @@ > ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \ > -I$(srctree)/arch/arm/plat-orion/include > > -AFLAGS_coherency_ll.o := -Wa,-march=armv7-a > +AFLAGS_coherency_ll.o := -Wa,-march=armv7-a > > -obj-y += system-controller.o > -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o > -obj-$(CONFIG_SMP) += platsmp.o headsmp.o > -obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o > +obj-$(CONFIG_MACH_ARMADA_370_XP) += $(armada-y) > +armada-y += system-controller.o > +armada-y += armada-370-xp.o > +armada-y += irq-armada-370-xp.o > +armada-y += addr-map.o > +armada-y += coherency.o > +armada-y += coherency_ll.o > +armada-y += pmsu.o > +armada-$(CONFIG_SMP) += platsmp.o headsmp.o > +armada-$(CONFIG_HOTPLUG_CPU) += hotplug.o > I have also tested your patch with a config with SMP, MVEBU, SMP and not MACH_ARMADA_370_XP. It fixes the build error. You can add my Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com> How do you want to proceed? As this patch come from you you should have it somewhere in your git tree, but I can take care of submitting a proper patch (ie with a commit log) if you want. Regards,
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile index 99df4df..c0434dc 100644 --- a/arch/arm/mach-mvebu/Makefile +++ b/arch/arm/mach-mvebu/Makefile @@ -1,9 +1,15 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \ -I$(srctree)/arch/arm/plat-orion/include -AFLAGS_coherency_ll.o := -Wa,-march=armv7-a +AFLAGS_coherency_ll.o := -Wa,-march=armv7-a -obj-y += system-controller.o -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o -obj-$(CONFIG_SMP) += platsmp.o headsmp.o -obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o +obj-$(CONFIG_MACH_ARMADA_370_XP) += $(armada-y) +armada-y += system-controller.o +armada-y += armada-370-xp.o +armada-y += irq-armada-370-xp.o +armada-y += addr-map.o +armada-y += coherency.o +armada-y += coherency_ll.o +armada-y += pmsu.o +armada-$(CONFIG_SMP) += platsmp.o headsmp.o +armada-$(CONFIG_HOTPLUG_CPU) += hotplug.o