| Message ID | 496565EC904933469F292DDA3F1663E602877517C9@dlee06.ent.ti.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Wed, Feb 25, 2009 at 7:32 PM, Guzman Lugo, Fernando <x0095840@ti.com> wrote: > From d3aeedc4677ebe6fdfb7f9f68b72ad5dc96463f0 Mon Sep 17 00:00:00 2001 > From: Fernando Guzman Lugo <x0095840@ti.com> > Date: Wed, 25 Feb 2009 10:19:12 -0600 > Subject: [PATCH] DSPBRIDGE: Remove variables not used in cfgdefs.h > > This patch removes some variable that are not used. > Signed-off-by: Guzman Lugo Fernando <x0095840@ti.com> > --- >  arch/arm/plat-omap/include/dspbridge/cfgdefs.h |  10 ---------- >  drivers/dsp/bridge/rmgr/drv.c          |   2 -- >  2 files changed, 0 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > index e7633b5..34a28f8 > --- a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > +++ b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > @@ -77,15 +77,6 @@ >         u8 bIRQAttrib;  /* IRQ Attribute */ >         u32 dwOffsetForMonitor; /* The Shared memory starts from >                     * dwMemBase + this offset */ > -        u32 dwBusType;  /* Bus type for this device */ > -        u32 dwProgBase; /* DSP ProgBase */ > -        u32 dwProgLength;    /* DSP ProgBase Length */ > -        u32 dwRegBase;  /* DSP memory mapped register base */ > -        u32 dwRegLength;     /* DSP Register Base Length */ > -        u32 ClientHandle;    /* Client Handle */ > -        u32 SocketHandle;    /* Socket and Function Pair */ > -        u32 CardInfo;  /* This will be used as a context data in > -                 * in the CardRequestIRQ */ >     /* >     *  Info needed by NODE for allocating channels to communicate with RMS: >     *    dwChnlOffset:    Offset of RMS channels. Lower channels are > @@ -102,7 +93,6 @@ >         void __iomem *dwWdTimerDspBase; >         void __iomem *dwMboxBase; >         void __iomem *dwDmmuBase; > -        u32 *dwDipiBase; >         void __iomem *dwSysCtrlBase; >     } ; > > diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c > index 2241f48..160d730 > --- a/drivers/dsp/bridge/rmgr/drv.c > +++ b/drivers/dsp/bridge/rmgr/drv.c > @@ -1733,7 +1733,6 @@ static DSP_STATUS RequestBridgeResources(u32 dwContext, s32 bRequest) >         /* Second window is for DSP external memory shared with MPU */ >         if (DSP_SUCCEEDED(status)) { >             /* for Linux, these are hard-coded values */ > -            pResources->dwBusType = 0; >             pResources->bIRQRegisters = 0; >             pResources->bIRQAttrib = 0; >             pResources->dwOffsetForMonitor = 0; > @@ -1856,7 +1855,6 @@ static DSP_STATUS RequestBridgeResourcesDSP(u32 dwContext, s32 bRequest) >         } >         if (DSP_SUCCEEDED(status)) { >             /* for Linux, these are hard-coded values */ > -            pResources->dwBusType = 0; >             pResources->bIRQRegisters = 0; >             pResources->bIRQAttrib = 0; >             pResources->dwOffsetForMonitor = 0; > -- > 1.5.6.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Can't apply this one as I guess your base tree has missed the following patch: Author: Ramesh Gupta G <grgupta@ti.com> Date: Fri Feb 13 14:51:19 2009 +0530 DSPBRIDGE DVFS and offmode support Cheers, Ameya. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ok, let me check, I think I didn't use the same base tree. Regards, Fernando. -----Original Message----- From: Ameya Palande [mailto:2ameya@gmail.com] Sent: Monday, March 02, 2009 7:10 AM To: Guzman Lugo, Fernando Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH][OMAPZOOM] DSPBRIDGE: Remove variables not used in cfgdefs.h Hi, On Wed, Feb 25, 2009 at 7:32 PM, Guzman Lugo, Fernando <x0095840@ti.com> wrote: > From d3aeedc4677ebe6fdfb7f9f68b72ad5dc96463f0 Mon Sep 17 00:00:00 2001 > From: Fernando Guzman Lugo <x0095840@ti.com> > Date: Wed, 25 Feb 2009 10:19:12 -0600 > Subject: [PATCH] DSPBRIDGE: Remove variables not used in cfgdefs.h > > This patch removes some variable that are not used. > Signed-off-by: Guzman Lugo Fernando <x0095840@ti.com> > --- >  arch/arm/plat-omap/include/dspbridge/cfgdefs.h |  10 ---------- >  drivers/dsp/bridge/rmgr/drv.c          |   2 -- >  2 files changed, 0 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > index e7633b5..34a28f8 > --- a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > +++ b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h > @@ -77,15 +77,6 @@ >         u8 bIRQAttrib;  /* IRQ Attribute */ >         u32 dwOffsetForMonitor; /* The Shared memory starts from >                     * dwMemBase + this offset */ > -        u32 dwBusType;  /* Bus type for this device */ > -        u32 dwProgBase; /* DSP ProgBase */ > -        u32 dwProgLength;    /* DSP ProgBase Length */ > -        u32 dwRegBase;  /* DSP memory mapped register base */ > -        u32 dwRegLength;     /* DSP Register Base Length */ > -        u32 ClientHandle;    /* Client Handle */ > -        u32 SocketHandle;    /* Socket and Function Pair */ > -        u32 CardInfo;  /* This will be used as a context data in > -                 * in the CardRequestIRQ */ >     /* >     *  Info needed by NODE for allocating channels to communicate with RMS: >     *    dwChnlOffset:    Offset of RMS channels. Lower channels are > @@ -102,7 +93,6 @@ >         void __iomem *dwWdTimerDspBase; >         void __iomem *dwMboxBase; >         void __iomem *dwDmmuBase; > -        u32 *dwDipiBase; >         void __iomem *dwSysCtrlBase; >     } ; > > diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c > index 2241f48..160d730 > --- a/drivers/dsp/bridge/rmgr/drv.c > +++ b/drivers/dsp/bridge/rmgr/drv.c > @@ -1733,7 +1733,6 @@ static DSP_STATUS RequestBridgeResources(u32 dwContext, s32 bRequest) >         /* Second window is for DSP external memory shared with MPU */ >         if (DSP_SUCCEEDED(status)) { >             /* for Linux, these are hard-coded values */ > -            pResources->dwBusType = 0; >             pResources->bIRQRegisters = 0; >             pResources->bIRQAttrib = 0; >             pResources->dwOffsetForMonitor = 0; > @@ -1856,7 +1855,6 @@ static DSP_STATUS RequestBridgeResourcesDSP(u32 dwContext, s32 bRequest) >         } >         if (DSP_SUCCEEDED(status)) { >             /* for Linux, these are hard-coded values */ > -            pResources->dwBusType = 0; >             pResources->bIRQRegisters = 0; >             pResources->bIRQAttrib = 0; >             pResources->dwOffsetForMonitor = 0; > -- > 1.5.6.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Can't apply this one as I guess your base tree has missed the following patch: Author: Ramesh Gupta G <grgupta@ti.com> Date: Fri Feb 13 14:51:19 2009 +0530 DSPBRIDGE DVFS and offmode support Cheers, Ameya. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h index e7633b5..34a28f8 --- a/arch/arm/plat-omap/include/dspbridge/cfgdefs.h +++ b/arch/arm/plat-omap/include/dspbridge/cfgdefs.h @@ -77,15 +77,6 @@ u8 bIRQAttrib; /* IRQ Attribute */ u32 dwOffsetForMonitor; /* The Shared memory starts from * dwMemBase + this offset */ - u32 dwBusType; /* Bus type for this device */ - u32 dwProgBase; /* DSP ProgBase */ - u32 dwProgLength; /* DSP ProgBase Length */ - u32 dwRegBase; /* DSP memory mapped register base */ - u32 dwRegLength; /* DSP Register Base Length */ - u32 ClientHandle; /* Client Handle */ - u32 SocketHandle; /* Socket and Function Pair */ - u32 CardInfo; /* This will be used as a context data in - * in the CardRequestIRQ */ /* * Info needed by NODE for allocating channels to communicate with RMS: * dwChnlOffset: Offset of RMS channels. Lower channels are @@ -102,7 +93,6 @@ void __iomem *dwWdTimerDspBase; void __iomem *dwMboxBase; void __iomem *dwDmmuBase; - u32 *dwDipiBase; void __iomem *dwSysCtrlBase; } ; diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c index 2241f48..160d730 --- a/drivers/dsp/bridge/rmgr/drv.c +++ b/drivers/dsp/bridge/rmgr/drv.c @@ -1733,7 +1733,6 @@ static DSP_STATUS RequestBridgeResources(u32 dwContext, s32 bRequest) /* Second window is for DSP external memory shared with MPU */ if (DSP_SUCCEEDED(status)) { /* for Linux, these are hard-coded values */ - pResources->dwBusType = 0; pResources->bIRQRegisters = 0; pResources->bIRQAttrib = 0; pResources->dwOffsetForMonitor = 0; @@ -1856,7 +1855,6 @@ static DSP_STATUS RequestBridgeResourcesDSP(u32 dwContext, s32 bRequest) } if (DSP_SUCCEEDED(status)) { /* for Linux, these are hard-coded values */ - pResources->dwBusType = 0; pResources->bIRQRegisters = 0; pResources->bIRQAttrib = 0; pResources->dwOffsetForMonitor = 0;