From patchwork Thu Apr 2 14:20:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 15920 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n32EME8d020557 for ; Thu, 2 Apr 2009 14:22:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755213AbZDBOVp (ORCPT ); Thu, 2 Apr 2009 10:21:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754196AbZDBOVp (ORCPT ); Thu, 2 Apr 2009 10:21:45 -0400 Received: from smtp.nokia.com ([192.100.122.233]:49752 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756111AbZDBOVp (ORCPT ); Thu, 2 Apr 2009 10:21:45 -0400 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx06.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n32ELFOq022828; Thu, 2 Apr 2009 17:21:37 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 2 Apr 2009 17:21:07 +0300 Received: from mgw-int01.ntc.nokia.com ([172.21.143.96]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 2 Apr 2009 17:21:06 +0300 Received: from [172.21.36.62] (esdhcp03662.research.nokia.com [172.21.36.62]) by mgw-int01.ntc.nokia.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id n32EL4CY018875; Thu, 2 Apr 2009 17:21:05 +0300 Message-ID: <49D4C9B8.10806@nokia.com> Date: Thu, 02 Apr 2009 17:20:40 +0300 From: Roger Quadros User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: tony@atomide.com CC: linux-omap@vger.kernel.org, Artem Bityutskiy Subject: [PATCH] ARM: OMAP3: Clean up spurious interrupt check logic X-OriginalArrivalTime: 02 Apr 2009 14:21:06.0394 (UTC) FILETIME=[42D093A0:01C9B39E] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Roger Quadros Date: Thu, 2 Apr 2009 16:41:00 +0300 Subject: [PATCH] ARM: OMAP3: Clean up spurious interrupt check logic SPURIOUSIRQ is contained in bits 31:7 of INTC_SIR, so INTC_SIR must be right shifted by 7, not 6. No change in logic, only changes for better readability. Refer to register definition of INTCPS_SIR_IRQ in OMAP3 Manual. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/irq.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 2842fe8..296ab86 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c @@ -73,9 +73,9 @@ static int omap_check_spurious(unsigned int irq) u32 sir, spurious; sir = intc_bank_read_reg(&irq_banks[0], INTC_SIR); - spurious = sir >> 6; + spurious = sir >> 7; - if (spurious > 1) { + if (spurious) { printk(KERN_WARNING "Spurious irq %i: 0x%08x, please flush " "posted write for irq %i\n", irq, sir, previous_irq);