From patchwork Wed Nov 28 06:09:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 1814131 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 3E3053FC54 for ; Wed, 28 Nov 2012 06:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751220Ab2K1GJj (ORCPT ); Wed, 28 Nov 2012 01:09:39 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:50654 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110Ab2K1GJi (ORCPT ); Wed, 28 Nov 2012 01:09:38 -0500 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id qAS69YL6015576; Wed, 28 Nov 2012 00:09:35 -0600 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id qAS69Wld021849; Wed, 28 Nov 2012 11:39:32 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Wed, 28 Nov 2012 11:39:32 +0530 Received: from [172.24.136.83] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id qAS69UBY029403; Wed, 28 Nov 2012 11:39:30 +0530 Message-ID: <50B5AAB4.9010103@ti.com> Date: Wed, 28 Nov 2012 11:39:56 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Jon Hunter CC: Tony Lindgren , linux-omap , linux-arm Subject: Re: [PATCH 1/3] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c References: <1354068915-3378-1-git-send-email-jon-hunter@ti.com> <1354068915-3378-2-git-send-email-jon-hunter@ti.com> In-Reply-To: <1354068915-3378-2-git-send-email-jon-hunter@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wednesday 28 November 2012 07:45 AM, Jon Hunter wrote: > In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time > counter), the function realtime_counter_init() was added. However, if > the kernel configuration option CONFIG_SOC_OMAP5 is not selected then > the following compiler warning is observed. > > CC arch/arm/mach-omap2/timer.o > arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ > defined but not used [-Wunused-function] > > Commit fa6d79d also introduced the kernel configuration option > CONFIG_SOC_HAS_REALTIME_COUNTER. If this option is not selected then the > a stub function for realtime_counter_init() is defined. > > The option CONFIG_SOC_HAS_REALTIME_COUNTER and stub function are not > really needed because ... > > 1. For non-OMAP5 devices, there is no realtime counter and so > realtime_counter_init() function is not used. > 2. For OMAP5 devices, CONFIG_SOC_HAS_REALTIME_COUNTER is always selected > and cannot be disabled, so the stub function for realtime_counter_init() > is never used. > > Fix this warning by removing the kernel configuration option > CONFIG_SOC_HAS_REALTIME_COUNTER and stub function, and only include > the function realtime_counter_init() if CONFIG_SOC_OMAP5 is selected. > > Cc: Santosh Shilimkar > > Reported-by: Tony Lindgren > Signed-off-by: Jon Hunter > --- The #ifdef was avoided because the real-time counter can be used on other future SOCs. And the those SOCs just select SOC_HAS_REALTIME_COUNTER. And that stub was added because OMAP5 can work without real-time counter configuration enabled using 32K counter. But since we are any way have that SOC_HAS_REALTIME_COUNTER always set for SOC which wants to use it, we can actually remove the stub and hence avoid the warning. Let me know if below patch is ok with you ? attached the same for mailer issues From e000aa13e47e29fbe3473bfd0277cb057c3160cc Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Wed, 28 Nov 2012 11:28:57 +0530 Subject: [PATCH] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time counter), the function realtime_counter_init() was added. However, if the kernel configuration option CONFIG_SOC_OMAP5 is not selected then the following compiler warning is observed. CC arch/arm/mach-omap2/timer.o arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ defined but not used [-Wunused-function] It is because of the stub init function which was added for the cases where realtime_counter_init() is called with !CONFIG_SOC_HAS_REALTIME_COUNTER. This is actually not necessary since the SOC which need this feature will explicitly select the configuration. So just drop the unused stub to avoid the build warning. Patch is made after seeing Jon's patch which was wrapping the real-time counter code under needed SOC #ifdef Cc: Jon Hunter Reported-by: Tony Lindgren Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/timer.c | 3 --- 1 file changed, 3 deletions(-) From e000aa13e47e29fbe3473bfd0277cb057c3160cc Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Wed, 28 Nov 2012 11:28:57 +0530 Subject: [PATCH] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time counter), the function realtime_counter_init() was added. However, if the kernel configuration option CONFIG_SOC_OMAP5 is not selected then the following compiler warning is observed. CC arch/arm/mach-omap2/timer.o arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ defined but not used [-Wunused-function] It is because of the stub init function which was added for the cases where realtime_counter_init() is called with !CONFIG_SOC_HAS_REALTIME_COUNTER. This is actually not necessary since the SOC which need this feature will explicitly select the configuration. So just drop the unused stub to avoid the build warning. Patch is made after seeing Jon's patch which was wrapping the real-time counter code under needed SOC #ifdef Cc: Jon Hunter Reported-by: Tony Lindgren Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 69e4663..79d8e6b 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -428,9 +428,6 @@ static void __init realtime_counter_init(void) iounmap(base); } -#else -static inline void __init realtime_counter_init(void) -{} #endif #define OMAP_SYS_TIMER_INIT(name, clkev_nr, clkev_src, \ -- 1.7.9.5