From patchwork Mon Apr 28 09:07:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4075881 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5FC3FBFF02 for ; Mon, 28 Apr 2014 09:07:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81A5C202C8 for ; Mon, 28 Apr 2014 09:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91456202B4 for ; Mon, 28 Apr 2014 09:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754375AbaD1JHm (ORCPT ); Mon, 28 Apr 2014 05:07:42 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:62867 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbaD1JHi (ORCPT ); Mon, 28 Apr 2014 05:07:38 -0400 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue001) with ESMTP (Nemesis) id 0MLnvv-1WeQPb1xTP-000v5n; Mon, 28 Apr 2014 11:07:04 +0200 From: Arnd Bergmann To: Linus Walleij Cc: Javier Martinez Canillas , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: [PATCH] gpio: always enable GPIO_OMAP on ARCH_OMAP Date: Mon, 28 Apr 2014 11:07:03 +0200 Message-ID: <5523458.JVZJJObMjC@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:wZ4TA4ralx61x3Az/ChQDBUUv0+d+2CAXulU3C0+ot9 PRPCwzW0Wrr9c+hkorBQvEhg3F4K1Af00WuO7dMA89rEzCrMuA VosZ4Lv5CxuFN3U0sBcNEwrnJfpoY9I3ErJzQnXyHg8ooKaGUT 5rJuEntt3bbLyzBcSj81sEJLNw0+yfc5FY2jXaAWkFQ4DysSOF Ps9SFFnEVYj17hHjh9yp+Z6Fu0SbuzAlyhErPoA3ig4FIvsvXH vv8QOdME/z0KF3eEwDHZ1cZAX7bUEM+XjbbYrgd9wzZnOgSAtC rdfmvOvZeaNFzvsrr8/Bb5wMHPpSa3IXZXV+b4cNi8OJ9jQ67x wehSxIs1KuQ6FA58o7c0= Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 4df42de9d3e "gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP" made it possible to build OMAP kernels without the GPIO driver, which at least on OMAP2 and OMAP3 causes build errors because of functions used by the platform power management code: arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': arch/arm/mach-omap2/pm24xx.c:129: undefined reference to `omap2_gpio_prepare_for_idle' arch/arm/mach-omap2/pm24xx.c:129: undefined reference to `omap2_gpio_resume_after_idle' We presumably always want the GPIO driver on OMAP, so this adds a slightly broader dependency and only allows disabling the driver only when no OMAP2PLUS platform is selected. However, it seems entirely reasonable to include the driver in build tests on other platforms, so we should also allow building it for COMPILE_TEST builds and select the required GENERIC_IRQ_CHIP that may not already be enabled on other platforms. Signed-off-by: Arnd Bergmann Acked-by: Javier Martinez Canillas --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index c58b828..c8c42be 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -244,9 +244,10 @@ config GPIO_OCTEON family of SOCs. config GPIO_OMAP - bool "TI OMAP GPIO support" + bool "TI OMAP GPIO support" if COMPILE_TEST && !ARCH_OMAP2PLUS default y if ARCH_OMAP - depends on ARM && ARCH_OMAP + depends on ARM + select GENERIC_IRQ_CHIP select GPIOLIB_IRQCHIP help Say yes here to enable GPIO support for TI OMAP SoCs.