From patchwork Wed Apr 15 08:07:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 6219211 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AE3EBBF4A6 for ; Wed, 15 Apr 2015 08:08:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D41D52017E for ; Wed, 15 Apr 2015 08:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED8E520376 for ; Wed, 15 Apr 2015 08:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbbDOIIF (ORCPT ); Wed, 15 Apr 2015 04:08:05 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:53954 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbbDOIH6 (ORCPT ); Wed, 15 Apr 2015 04:07:58 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id t3F87gxP029179; Wed, 15 Apr 2015 03:07:42 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id t3F87eao025032; Wed, 15 Apr 2015 03:07:40 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.224.2; Wed, 15 Apr 2015 03:07:40 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t3F87be8004649; Wed, 15 Apr 2015 03:07:38 -0500 Message-ID: <552E1C4A.7060503@ti.com> Date: Wed, 15 Apr 2015 11:07:38 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Gregory CLEMENT CC: , , , , , , Subject: Re: [PATCH] genirq: provide dummy set_irq_wake() References: <1427721345-6402-1-git-send-email-rogerq@ti.com> <552CE847.7060103@ti.com> <552D1DEF.6080303@free-electrons.com> In-Reply-To: <552D1DEF.6080303@free-electrons.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Gregory, On 14/04/15 17:02, Gregory CLEMENT wrote: > Hi Roger, > > On 14/04/2015 12:13, Roger Quadros wrote: >> Hi Thomas, >> >> On 30/03/15 16:15, Roger Quadros wrote: >>> Without this system suspend is broken on systems that have >>> drivers calling enable/disable_irq_wake() for interrupts based off >>> the dummy irq hook. >>> (e.g. drivers/gpio/gpio-pcf857x.c) >>> >>> http://article.gmane.org/gmane.linux.kernel/1879035 >>> >>> Signed-off-by: Roger Quadros >> >> Any comments on this patch? > > I read the url you pointed and I wonder why, at then end, did > you choose to add a dummy set_irq_wake() instead of using > IRQCHIP_SKIP_SET_WAKE ? You mean like this? This works as well and is better. I'll post a v2. cheers, -roger >> >>> --- >>> kernel/irq/dummychip.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c >>> index 988dc58..2405d7a 100644 >>> --- a/kernel/irq/dummychip.c >>> +++ b/kernel/irq/dummychip.c >>> @@ -32,6 +32,11 @@ static unsigned int noop_ret(struct irq_data *data) >>> return 0; >>> } >>> >>> +static int noop_int_ret(struct irq_data *data, unsigned int val) >>> +{ >>> + return 0; >>> +} >>> + >>> /* >>> * Generic no controller implementation >>> */ >>> @@ -57,5 +62,6 @@ struct irq_chip dummy_irq_chip = { >>> .irq_ack = noop, >>> .irq_mask = noop, >>> .irq_unmask = noop, >>> + .irq_set_wake = noop_int_ret, >>> }; >>> EXPORT_SYMBOL_GPL(dummy_irq_chip); >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c index 988dc58..2feb6fe 100644 --- a/kernel/irq/dummychip.c +++ b/kernel/irq/dummychip.c @@ -57,5 +57,6 @@ struct irq_chip dummy_irq_chip = { .irq_ack = noop, .irq_mask = noop, .irq_unmask = noop, + .flags = IRQCHIP_SKIP_SET_WAKE, }; EXPORT_SYMBOL_GPL(dummy_irq_chip);