From patchwork Thu Mar 31 15:07:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 8714031 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3049B9F30C for ; Thu, 31 Mar 2016 15:08:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 620CE2028D for ; Thu, 31 Mar 2016 15:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C3CF20272 for ; Thu, 31 Mar 2016 15:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756861AbcCaPIX (ORCPT ); Thu, 31 Mar 2016 11:08:23 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:33603 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbcCaPIW (ORCPT ); Thu, 31 Mar 2016 11:08:22 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id u2VF7XXR016632; Thu, 31 Mar 2016 10:07:33 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id u2VF7Xdw027923; Thu, 31 Mar 2016 10:07:33 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.224.2; Thu, 31 Mar 2016 10:07:32 -0500 Received: from [172.22.235.58] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id u2VF7Tqi004576; Thu, 31 Mar 2016 10:07:30 -0500 Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child To: Felipe Balbi , "Thang Q. Nguyen" References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> <56FBDA0D.4030507@ti.com> <87egashxz8.fsf@intel.com> <87k2kjgjjf.fsf@intel.com> CC: Greg Kroah-Hartman , , , , , Arnd Bergmann , "Karicheri, Muralidharan" , Peter Ujfalusi , Phong Vo , Loc Ho , patches , Santosh Shilimkar , "Ben Dooks (embedded platforms)" From: Grygorii Strashko Message-ID: <56FD3D2F.8070501@ti.com> Date: Thu, 31 Mar 2016 18:07:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87k2kjgjjf.fsf@intel.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/31/2016 11:04 AM, Felipe Balbi wrote: > "Thang Q. Nguyen" writes: >> [ text/plain ] >> Thanks Grygorii for information. >> I checked but do not see dma_init_dev_from_parent is used in >> linux-next repository. Can you give me more information for what >> branch I can checkout to use it for USB DWC3? > > dma_init_dev_from_parent() is still a proposal ;-) > Felipe, After some experiments I came up with below fix (not common, but fixes USB case on keystone 2). if you agree with proposed fix I'll send proper patches to fix usb_add_gadget_udc_release() and dwc3_host_init() in the same way. diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index c679f63..3fe1c65 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc3/host.c @@ -17,6 +17,7 @@ #include #include +#include #include "core.h" @@ -35,8 +36,6 @@ int dwc3_host_init(struct dwc3 *dwc) dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask); xhci->dev.parent = dwc->dev; - xhci->dev.dma_mask = dwc->dev->dma_mask; - xhci->dev.dma_parms = dwc->dev->dma_parms; dwc->xhci = xhci; @@ -62,6 +61,12 @@ int dwc3_host_init(struct dwc3 *dwc) phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy", dev_name(&xhci->dev)); + if (!dwc->dev->of_node) { + xhci->dev.dma_mask = dwc->dev->dma_mask; + xhci->dev.dma_parms = dwc->dev->dma_parms; + } else + of_dma_configure(&xhci->dev, dwc->dev->of_node); + ret = platform_device_add(xhci); if (ret) { dev_err(dwc->dev, "failed to register xHCI device\n");