[03/03] OMAP3 clock: Fix locking in notifier register

Commit Message

Rajendra Nayak March 20, 2009, 1:50 p.m. UTC

From: Rajendra Nayak <[e-mail]>

This patch avoids spinlocks being held when calling
blocking_notifier_chain_register().

Signed-off-by: Rajendra Nayak <[e-mail]>
Signed-off-by: Tero Kristo <[e-mail]>
---
 arch/arm/plat-omap/clock.c |    4 ++++
 1 files changed, 4 insertions(+)

To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: linux-omap-pm/arch/arm/plat-omap/clock.c
===================================================================
--- linux-omap-pm.orig/arch/arm/plat-omap/clock.c	2009-03-20 17:11:54.000000000 +0530
+++ linux-omap-pm/arch/arm/plat-omap/clock.c	2009-03-20 19:14:35.387298482 +0530
@@ -673,7 +673,11 @@  int clk_notifier_register(struct clk *cl
 		kfree(cn_new); /* didn't need it after all */
 	}
 
+	spin_unlock_irqrestore(&clockfw_lock, flags);
+
 	r = blocking_notifier_chain_register(&cn->notifier_head, nb);
+
+	spin_lock_irqsave(&clockfw_lock, flags);
 	if (!r) {
 		clkp = clk;
 		do {--