From patchwork Mon Mar 2 02:22:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongsoo Kim X-Patchwork-Id: 9485 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n222MfZA023266 for ; Mon, 2 Mar 2009 02:22:41 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504AbZCBCWl (ORCPT ); Sun, 1 Mar 2009 21:22:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751958AbZCBCWl (ORCPT ); Sun, 1 Mar 2009 21:22:41 -0500 Received: from rv-out-0506.google.com ([209.85.198.235]:1309 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbZCBCWk (ORCPT ); Sun, 1 Mar 2009 21:22:40 -0500 Received: by rv-out-0506.google.com with SMTP id g37so2036803rvb.1 for ; Sun, 01 Mar 2009 18:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=uxLcCsfzqKq5zdeQTrriiZ82pMq3lzmJA0QDJWidubU=; b=FLnBJTDZmg8pqctbNj431+V96FuMKOHrdd2PQN6Rb+FjWVsYtAWOvr3hWfNQoDaZYy QWptciF4sOP6JViglP7GRgP+ZMtgc+kHLZ/s84iQFi0YzJ7a6XkAzUJPoz6aI0eI4F02 JlgedpVhaGYU/Mw8/cN8IsM52fIeNPrYKSN1Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=f0/Bo4wkusbozfkrxB+7f7jCVghmXDU1JarTf5dqaW4nMWMX9awYkWqSi5y7JQpC9F 0112r85nD7a1tIM3ReAPZv2CFv+UPKCwxk4hCB8wkERsLH7eq13DT4TMNSX+uVeFCnZL c7QAYv4wSUUcorCYkdPZfAHHypSlk8tP5ePG8= MIME-Version: 1.0 Received: by 10.142.214.5 with SMTP id m5mr2723882wfg.266.1235960558173; Sun, 01 Mar 2009 18:22:38 -0800 (PST) Date: Mon, 2 Mar 2009 11:22:38 +0900 Message-ID: <5e9665e10903011822i5afbf588x8e9fc9596d94519a@mail.gmail.com> Subject: [OMAPZOOM][PATCH] CAM: Make PACK8 mode on CCDC work only with CCIR-656 From: "DongSoo(Nathaniel) Kim" To: "linux-media@vger.kernel.org" , "linux-omap@vger.kernel.org" Cc: svadivu@ti.com, p-kulkarni@ti.com, dongsoo45.kim@samsung.com, "kyungmin.park@samsung.com" , =?EUC-KR?B?sejH/MHY?= , "jongse.won@samsung.com" Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hello, Besides the patch I've posted couple of hours ago, there is one more thing in omap3 ispccdc.c. According to omap3 datasheet, PACK8 could be enabled only when CCDC_SYN_MODE is with CCIR-656 mode. If you try to use external camera module with ITU-R.601 mode without this patch, you could face weird data from your camera interface. Please find following patch, and any comments will be welcomed. Cheers, Nate From 23425c97233c93f9b572351d8a93a13ae3cb3188 Mon Sep 17 00:00:00 2001 From: Dongsoo Kim Date: Mon, 2 Mar 2009 11:01:14 +0900 Subject: [PATCH 2/2] CAM: Make PACK8 mode on CCDC work only with CCIR-656 Signed-off-by: Dongsoo Kim --- drivers/media/video/isp/ispccdc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/isp/ispccdc.c b/drivers/media/video/isp/ispccdc.c index 8f7e896..2945c6f 100644 --- a/drivers/media/video/isp/ispccdc.c +++ b/drivers/media/video/isp/ispccdc.c @@ -762,7 +762,8 @@ void ispccdc_config_sync_if(struct ispccdc_syncif syncif) switch (syncif.datsz) { case DAT8: syn_mode |= ISPCCDC_SYN_MODE_DATSIZ_8; - syn_mode |= ISPCCDC_SYN_MODE_PACK8; /* Added by MMS */ + if (syncif.bt_r656_en) + syn_mode |= ISPCCDC_SYN_MODE_PACK8; /* Added by MMS */ break; case DAT10: syn_mode |= ISPCCDC_SYN_MODE_DATSIZ_10;