| Message ID | 7771a9fb3b9133fc361c87970444c1a3918891d0.1477414105.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote: > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/arm/boot/dts/omap5-board-common.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > index b04adee..91456b4 100644 > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > @@ -124,6 +124,7 @@ > compatible = "ti,abe-twl6040"; > ti,model = "omap5-uevm"; > > + ti,jack_detection; ti,jack-detection > ti,mclk-freq = <19200000>; > > ti,mcpdm = <&mcpdm>; >
* Peter Ujfalusi <peter.ujfalusi@ti.com> [161025 09:54]: > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote: > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > > --- > > arch/arm/boot/dts/omap5-board-common.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > > index b04adee..91456b4 100644 > > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > > @@ -124,6 +124,7 @@ > > compatible = "ti,abe-twl6040"; > > ti,model = "omap5-uevm"; > > > > + ti,jack_detection; > > ti,jack-detection Also subject has baord-common for both :) Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>: > > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote: >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi >> index b04adee..91456b4 100644 >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi >> @@ -124,6 +124,7 @@ >> compatible = "ti,abe-twl6040"; >> ti,model = "omap5-uevm"; >> >> + ti,jack_detection; > > ti,jack-detection Hm. Looks as if we have found another bug: which one is correct? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289 Should I add another patch? > >> ti,mclk-freq = <19200000>; >> >> ti,mcpdm = <&mcpdm>; >> > > > -- > Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* H. Nikolaus Schaller <hns@goldelico.com> [161025 10:20]: > > > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>: > > > > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote: > >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > >> --- > >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > >> index b04adee..91456b4 100644 > >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi > >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > >> @@ -124,6 +124,7 @@ > >> compatible = "ti,abe-twl6040"; > >> ti,model = "omap5-uevm"; > >> > >> + ti,jack_detection; > > > > ti,jack-detection > > Hm. Looks as if we have found another bug: > which one is correct? > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15 > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289 > > Should I add another patch? We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use of ti,jack_detection. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi index b04adee..91456b4 100644 --- a/arch/arm/boot/dts/omap5-board-common.dtsi +++ b/arch/arm/boot/dts/omap5-board-common.dtsi @@ -124,6 +124,7 @@ compatible = "ti,abe-twl6040"; ti,model = "omap5-uevm"; + ti,jack_detection; ti,mclk-freq = <19200000>; ti,mcpdm = <&mcpdm>;
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/arm/boot/dts/omap5-board-common.dtsi | 1 + 1 file changed, 1 insertion(+)