From patchwork Wed Mar 11 15:29:35 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atal Shargorodsky X-Patchwork-Id: 11154 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2BFT9NQ004097 for ; Wed, 11 Mar 2009 15:30:55 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbZCKPaz (ORCPT ); Wed, 11 Mar 2009 11:30:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752645AbZCKPaz (ORCPT ); Wed, 11 Mar 2009 11:30:55 -0400 Received: from smtp.nokia.com ([192.100.105.134]:28511 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbZCKPay (ORCPT ); Wed, 11 Mar 2009 11:30:54 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx09.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n2BFUXdk020375; Wed, 11 Mar 2009 10:30:46 -0500 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 11 Mar 2009 17:30:17 +0200 Received: from mgw-int01.ntc.nokia.com ([172.21.143.96]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 11 Mar 2009 17:30:17 +0200 Received: from localhost.localdomain (esdhcp042174.research.nokia.com [172.21.42.174]) by mgw-int01.ntc.nokia.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id n2BFUB31017872; Wed, 11 Mar 2009 17:30:16 +0200 From: Atal Shargorodsky To: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.arm.linux.org.uk, Atal Shargorodsky Subject: [PATCH 3/6] OMAP: omap_wdt: Remove non-explanatory comments. Date: Wed, 11 Mar 2009 17:29:35 +0200 Message-Id: <7992fd993e5b420f9c2aac55f6e674169b36c666.1236609434.git.ext-atal.shargorodsky@nokia.com> X-Mailer: git-send-email 1.5.4.3 In-Reply-To: <0fe7f2934f8416e9b5f05e2f18766362560116ee.1236609434.git.ext-atal.shargorodsky@nokia.com> References: <> <1236785378-14640-1-git-send-email-ext-atal.shargorodsky@nokia.com> <0fe7f2934f8416e9b5f05e2f18766362560116ee.1236609434.git.ext-atal.shargorodsky@nokia.com> In-Reply-To: References: X-OriginalArrivalTime: 11 Mar 2009 15:30:17.0391 (UTC) FILETIME=[47E9F3F0:01C9A25E] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The call to clk_disable does need a trivial comment like /* Disable the clock */. Signed-off-by: Atal Shargorodsky --- drivers/watchdog/omap_wdt.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index 05dc55a..1364d7e 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -146,9 +146,9 @@ static int omap_wdt_open(struct inode *inode, struct file *file) return -EBUSY; if (wdev->mpu_wdt_ick) - clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */ + clk_enable(wdev->mpu_wdt_ick); - clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */ + clk_enable(wdev->mpu_wdt_fck); /* initialize prescaler */ while (__raw_readl(base + OMAP_WATCHDOG_WPS) & 0x01) @@ -178,9 +178,9 @@ static int omap_wdt_release(struct inode *inode, struct file *file) omap_wdt_disable(wdev); if (wdev->mpu_wdt_ick) - clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_ick); - clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_fck); #else printk(KERN_CRIT "omap_wdt: Unexpected close, not stopping!\n"); #endif @@ -345,9 +345,9 @@ static int __init omap_wdt_probe(struct platform_device *pdev) /* enable clocks for register access */ if (wdev->mpu_wdt_ick) - clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */ + clk_enable(wdev->mpu_wdt_ick); - clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */ + clk_enable(wdev->mpu_wdt_fck); omap_wdt_disable(wdev); omap_wdt_adjust_timeout(timer_margin); @@ -370,8 +370,8 @@ static int __init omap_wdt_probe(struct platform_device *pdev) /* disable clocks since we don't need them now */ if (wdev->mpu_wdt_ick) - clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */ - clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_ick); + clk_disable(wdev->mpu_wdt_fck); omap_wdt_dev = pdev;