From patchwork Fri Mar 6 13:34:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ari Kauppi X-Patchwork-Id: 10360 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n26Dbtom021200 for ; Fri, 6 Mar 2009 13:37:56 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756207AbZCFNgn (ORCPT ); Fri, 6 Mar 2009 08:36:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756198AbZCFNgm (ORCPT ); Fri, 6 Mar 2009 08:36:42 -0500 Received: from smtp.nokia.com ([192.100.122.230]:17078 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756207AbZCFNgl (ORCPT ); Fri, 6 Mar 2009 08:36:41 -0500 Received: from esebh105.NOE.Nokia.com (esebh105.ntc.nokia.com [172.21.138.211]) by mgw-mx03.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n26Da9vV006759; Fri, 6 Mar 2009 15:36:29 +0200 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by esebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 6 Mar 2009 15:35:26 +0200 Received: from mgw-int01.ntc.nokia.com ([172.21.143.96]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Fri, 6 Mar 2009 15:35:26 +0200 Received: from localhost.localdomain (ouped11936.nmp.nokia.com [172.23.119.36]) by mgw-int01.ntc.nokia.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id n26DZKdL000650; Fri, 6 Mar 2009 15:35:25 +0200 From: Ari Kauppi To: ben-linux@fluff.org Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org Subject: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED Date: Fri, 6 Mar 2009 15:34:54 +0200 Message-Id: <7d7e7dd1a4c64c732a21bdfcf2bd42556be708c3.1236345858.git.Ext-Ari.Kauppi@nokia.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: References: X-OriginalArrivalTime: 06 Mar 2009 13:35:26.0443 (UTC) FILETIME=[6885FBB0:01C99E60] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org I have observed some Spurious IRQ's for I2C1 when all kernel hacking options (and thus LOCKDEP) are disabled. Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help but IRQF_DISABLED is needed for proper behaviour. Signed-off-by: Ari Kauppi Acked-by: Felipe Balbi --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 0c3ed41..18af43f 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -847,7 +847,7 @@ omap_i2c_probe(struct platform_device *pdev) omap_i2c_init(dev); isr = (dev->rev < OMAP_I2C_REV_2) ? omap_i2c_rev1_isr : omap_i2c_isr; - r = request_irq(dev->irq, isr, 0, pdev->name, dev); + r = request_irq(dev->irq, isr, IRQF_DISABLED, pdev->name, dev); if (r) { dev_err(dev->dev, "failure requesting irq %i\n", dev->irq);