diff mbox

[2/2] am335x-evm: add bluetooth support

Message ID 8665E2433BC68541A24DFFCA87B70F5B236603EC@DFRE01.ent.ti.com
State New, archived
Headers show

Commit Message

Reizer, Eyal May 5, 2015, 6:06 a.m. UTC
Hi Rob,

Please ignore this patch. 
I have received pushback on a similar patch for a different platform (am437x-evm) and submitted a v2 (attached) that only initializes the uart without using the shared transport driver.


> -----Original Message-----
> From: Rob Herring [mailto:robherring2@gmail.com]
> Sent: Tuesday, May 05, 2015 1:28 AM
> To: Eyal Reizer
> Cc: Tony Lindgren; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Russell King - ARM Linux; linux-omap;
> devicetree@vger.kernel.org; Eliad Peller; Reizer, Eyal
> Subject: Re: [PATCH 2/2] am335x-evm: add bluetooth support
> 
> On Sun, May 3, 2015 at 7:19 AM, Eyal Reizer <eyalreizer@gmail.com> wrote:
> > From: Eliad Peller <eliad@wizery.com>
> >
> > uart1 is used for shared transport (used for multiplexing bluetooth
> > and nfc data). add the needed muxes and definitions.
> >
> > Signed-off-by: Eliad Peller <eliad@wizery.com>
> > Signed-off-by: Eyal Reizer <eyalr@ti.com>
> > ---
> >  arch/arm/boot/dts/am335x-evm.dts |   28
> ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-evm.dts
> > b/arch/arm/boot/dts/am335x-evm.dts
> > index 0f398fa..5968cde 100644
> > --- a/arch/arm/boot/dts/am335x-evm.dts
> > +++ b/arch/arm/boot/dts/am335x-evm.dts
> > @@ -135,6 +135,18 @@
> >                 };
> >         };
> >
> > +       kim {
> > +               compatible = "kim";
> 
> Who is kim?
> 
> > +               nshutdown_gpio = <117>; /* Bank3, pin21 */
> 
> We have a standard way to specify gpios.
> 
> > +               dev_name = "/dev/ttyS1";
> 
> Uh, Linux specific. No.
> 
> > +               flow_cntrl = <1>;
> > +               baud_rate = <3000000>;
> 
> I believe there are standard properties for uarts for both of these.
> 
> Is any of this documented?
> 
> Rob

Best Regards,
Eyal
From: Eliad Peller <eliad@wizery.com>

uart1 is used for connecting to wilink8 bluetooth subsystem.
add the needed muxes and definitions.

Signed-off-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
Changes in v2:
removed ti shared transport bindings

 arch/arm/boot/dts/am335x-evm.dts |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

--
1.7.9.5
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 0f398fa..765be27 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -191,6 +191,15 @@ 
                >;
        };

+       uart1_pins: pinmux_uart1_pins {
+               pinctrl-single,pins = <
+                       0x178 (PIN_INPUT | MUX_MODE0)           /* uart1_ctsn.uart1_ctsn */
+                       0x17C (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_rtsn.uart1_rtsn */
+                       0x180 (PIN_INPUT_PULLUP | MUX_MODE0)    /* uart1_rxd.uart1_rxd */
+                       0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_txd.uart1_txd */
+               >;
+       };
+
        clkout2_pin: pinmux_clkout2_pin {
                pinctrl-single,pins = <
                        0x1b4 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr1.clkout2 */
@@ -357,6 +366,13 @@ 
        status = "okay";
 };

+&uart1 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&uart1_pins>;
+
+       status = "okay";
+};
+
 &i2c0 {
        pinctrl-names = "default";
        pinctrl-0 = <&i2c0_pins>;