From patchwork Tue May 5 06:06:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Reizer, Eyal" X-Patchwork-Id: 6335581 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 49FE1BEEE5 for ; Tue, 5 May 2015 06:07:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 96C82202E9 for ; Tue, 5 May 2015 06:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0455202F0 for ; Tue, 5 May 2015 06:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755980AbbEEGHN (ORCPT ); Tue, 5 May 2015 02:07:13 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:38414 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755973AbbEEGHJ (ORCPT ); Tue, 5 May 2015 02:07:09 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id t4566gsX019779; Tue, 5 May 2015 01:06:42 -0500 Received: from DFRE71.ent.ti.com (dfre71.ent.ti.com [10.167.188.35]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id t4566e6r005344; Tue, 5 May 2015 01:06:41 -0500 Received: from DFRE01.ent.ti.com ([fe80::b027:5293:c8d8:d82a]) by DFRE71.ent.ti.com ([fe80::1d1a:fb50:7d9b:ab68%31]) with mapi id 14.03.0224.002; Tue, 5 May 2015 08:06:40 +0200 From: "Reizer, Eyal" To: Rob Herring , Eyal Reizer CC: Tony Lindgren , Rob Herring , "Pawel Moll" , Mark Rutland , Ian Campbell , Kumar Gala , "Russell King - ARM Linux" , linux-omap , "devicetree@vger.kernel.org" , Eliad Peller Subject: RE: [PATCH 2/2] am335x-evm: add bluetooth support Thread-Topic: [PATCH 2/2] am335x-evm: add bluetooth support Thread-Index: AQHQhZt1UJaKlZ8dU0uS12DkXZ35Qp1sRoEAgACgnLA= Date: Tue, 5 May 2015 06:06:39 +0000 Message-ID: <8665E2433BC68541A24DFFCA87B70F5B236603EC@DFRE01.ent.ti.com> References: <1430655569-27849-1-git-send-email-eyalr@ti.com> <1430655569-27849-2-git-send-email-eyalr@ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.167.188.42] x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Rob, Please ignore this patch. I have received pushback on a similar patch for a different platform (am437x-evm) and submitted a v2 (attached) that only initializes the uart without using the shared transport driver. > -----Original Message----- > From: Rob Herring [mailto:robherring2@gmail.com] > Sent: Tuesday, May 05, 2015 1:28 AM > To: Eyal Reizer > Cc: Tony Lindgren; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Russell King - ARM Linux; linux-omap; > devicetree@vger.kernel.org; Eliad Peller; Reizer, Eyal > Subject: Re: [PATCH 2/2] am335x-evm: add bluetooth support > > On Sun, May 3, 2015 at 7:19 AM, Eyal Reizer wrote: > > From: Eliad Peller > > > > uart1 is used for shared transport (used for multiplexing bluetooth > > and nfc data). add the needed muxes and definitions. > > > > Signed-off-by: Eliad Peller > > Signed-off-by: Eyal Reizer > > --- > > arch/arm/boot/dts/am335x-evm.dts | 28 > ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/arch/arm/boot/dts/am335x-evm.dts > > b/arch/arm/boot/dts/am335x-evm.dts > > index 0f398fa..5968cde 100644 > > --- a/arch/arm/boot/dts/am335x-evm.dts > > +++ b/arch/arm/boot/dts/am335x-evm.dts > > @@ -135,6 +135,18 @@ > > }; > > }; > > > > + kim { > > + compatible = "kim"; > > Who is kim? > > > + nshutdown_gpio = <117>; /* Bank3, pin21 */ > > We have a standard way to specify gpios. > > > + dev_name = "/dev/ttyS1"; > > Uh, Linux specific. No. > > > + flow_cntrl = <1>; > > + baud_rate = <3000000>; > > I believe there are standard properties for uarts for both of these. > > Is any of this documented? > > Rob Best Regards, Eyal From: Eliad Peller uart1 is used for connecting to wilink8 bluetooth subsystem. add the needed muxes and definitions. Signed-off-by: Eliad Peller Signed-off-by: Eyal Reizer --- Changes in v2: removed ti shared transport bindings arch/arm/boot/dts/am335x-evm.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) -- 1.7.9.5 diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 0f398fa..765be27 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -191,6 +191,15 @@ >; }; + uart1_pins: pinmux_uart1_pins { + pinctrl-single,pins = < + 0x178 (PIN_INPUT | MUX_MODE0) /* uart1_ctsn.uart1_ctsn */ + 0x17C (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_rtsn.uart1_rtsn */ + 0x180 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart1_rxd.uart1_rxd */ + 0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_txd.uart1_txd */ + >; + }; + clkout2_pin: pinmux_clkout2_pin { pinctrl-single,pins = < 0x1b4 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* xdma_event_intr1.clkout2 */ @@ -357,6 +366,13 @@ status = "okay"; }; +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>; + + status = "okay"; +}; + &i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>;