From patchwork Fri Jul 1 07:57:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 9209397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B3F526075F for ; Fri, 1 Jul 2016 07:58:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5CFC28513 for ; Fri, 1 Jul 2016 07:58:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9968328690; Fri, 1 Jul 2016 07:58:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17E4228513 for ; Fri, 1 Jul 2016 07:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbcGAH6b (ORCPT ); Fri, 1 Jul 2016 03:58:31 -0400 Received: from mga14.intel.com ([192.55.52.115]:58442 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcGAH61 (ORCPT ); Fri, 1 Jul 2016 03:58:27 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 01 Jul 2016 00:58:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,555,1459839600"; d="asc'?scan'208";a="986925939" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.160]) by orsmga001.jf.intel.com with ESMTP; 01 Jul 2016 00:58:23 -0700 From: Felipe Balbi To: Roger Quadros Cc: stern@rowland.harvard.edu, sre@kernel.org, peter.chen@nxp.com, tony@atomide.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm' In-Reply-To: <577525BF.3060509@ti.com> References: <1467276056-19357-1-git-send-email-rogerq@ti.com> <8760srgf00.fsf@linux.intel.com> <577525BF.3060509@ti.com> User-Agent: Notmuch/0.22+58~g3a45d29 (https://notmuchmail.org) Emacs/25.0.95.1 (x86_64-pc-linux-gnu) Date: Fri, 01 Jul 2016 10:57:43 +0300 Message-ID: <878txloknc.fsf@linux.intel.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Roger Quadros writes: >>> NOP_USB_XCEIV is used not only by gadget drivers but by >>> host drivers as well e.g. EHCI_OMAP. >>> >>> commit 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") >>> made it so that NOP_USB_XCEIV can't be built-in if USB_GADGET is 'm'. >>> But this prevents EHCI_OMAP to be built-in if USB_GADGET is 'm'. >>> >>> Fix this undesired behaviour by moving usb_gadget_vbus_connect/disconnect() >>> to usb/gadget.h so that NOP_USB_XCEIV has no build dependency >>> on USB_GADGET. >>> >>> Retain the original Kconfig behaviour i.e. NOP_USB_XCEIV is selected >>> by drivers that need it. >> >> no, this is the wrong way to fix this. NOP _has_ a dependency on the >> Gadget API if it calls Gadget API functions. Dependencies are proper. >> >> Maybe the reason for the problem is that we ended up adding far too much >> code to phy-generic.c itself. Maybe it shouldn't know about clks and >> interrupts. The original idea of that driver was to simply satisfy a >> requirement to have a valid transceiver by some platforms. Maybe we >> should fix that instead. Moving functions around to workaround a problem >> is not the way to go, sorry. >> > OK but something that was working all these years is broken by your > patch. > Do you mind fixing it please? Or at least let me know how you want to > get it fixed. diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 2e710a4cca52..89fd095ca33d 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -180,7 +180,7 @@ config USB_EHCI_MXC config USB_EHCI_HCD_OMAP tristate "EHCI support for OMAP3 and later chips" depends on ARCH_OMAP - depends on NOP_USB_XCEIV + depends on USB_PHY default y ---help--- Enables support for the on-chip EHCI controller on