From patchwork Fri Dec 17 22:54:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 417511 X-Patchwork-Delegate: paul@pwsan.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBHNMAdU015506 for ; Fri, 17 Dec 2010 23:22:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004Ab0LQWye (ORCPT ); Fri, 17 Dec 2010 17:54:34 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:58148 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755153Ab0LQWye (ORCPT ); Fri, 17 Dec 2010 17:54:34 -0500 Received: by gyb11 with SMTP id 11so454612gyb.19 for ; Fri, 17 Dec 2010 14:54:33 -0800 (PST) Received: by 10.100.134.13 with SMTP id h13mr497042and.184.1292626473213; Fri, 17 Dec 2010 14:54:33 -0800 (PST) Received: from localhost (c-24-18-179-55.hsd1.wa.comcast.net [24.18.179.55]) by mx.google.com with ESMTPS id b27sm4786210ana.28.2010.12.17.14.54.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 17 Dec 2010 14:54:32 -0800 (PST) From: Kevin Hilman To: Nishanth Menon Cc: Vishwanath Sripathy , linux-omap , Eduardo Valentin , Tony Lindgren Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if < ES1.2 Organization: Deep Root Systems, LLC References: <1291395818-8639-1-git-send-email-nm@ti.com> <1291395818-8639-6-git-send-email-nm@ti.com> <2cdf7d3d033ee2c88b6f2d4cfa37d9db@mail.gmail.com> <4D0622FE.2070801@ti.com> <4D062806.6090201@ti.com> <4D062F81.407@ti.com> <96505dfaee73d6785e153ccf5c2856d3@mail.gmail.com> <6f507e24d6ae188e265913e85e815f82@mail.gmail.com> <4D063344.2010001@ti.com> <37de3932d97af8e1882a08dd37242a17@mail.gmail.com> <4D063599.9080905@ti.com> <87ei9l10mk.fsf@deeprootsystems.com> <4D0933C6.1060404@ti.com> <87wrnaions.fsf@deeprootsystems.com> <4D0957C7.4010907@ti.com> <4D096BC4.4040009@ti.com> <87tyidczpy.fsf@deeprootsystems.com> <4D0AB7C3.1050809@ti.com> Date: Fri, 17 Dec 2010 14:54:29 -0800 In-Reply-To: <4D0AB7C3.1050809@ti.com> (Nishanth Menon's message of "Thu, 16 Dec 2010 19:07:15 -0600") Message-ID: <87oc8k6me2.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Fri, 17 Dec 2010 23:22:15 +0000 (UTC) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index 81b0a90..92873b4 100644 --- a/arch/arm/mach-omap2/cpuidle34xx.c +++ b/arch/arm/mach-omap2/cpuidle34xx.c @@ -452,6 +452,15 @@ void omap_init_power_states(void) omap3_power_states[OMAP3_STATE_C7].core_state = PWRDM_POWER_OFF; omap3_power_states[OMAP3_STATE_C7].flags = CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_CHECK_BM; + + /* + * Erratum i583: implementation for ES rev < Es1.2 on 3630 + * We cannot enable OFF mode in a stable form for previous + * revisions, transition instead to RET + */ + if (IS_PM34XX_ERRATUM(SDRC_WAKEUP_ERRATUM_i583) + omap3_power_states[OMAP3_STATE_C7].valid = 0; + }