From patchwork Mon Dec 13 14:43:32 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 406422 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBDEhcs3016348 for ; Mon, 13 Dec 2010 14:43:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817Ab0LMOnh (ORCPT ); Mon, 13 Dec 2010 09:43:37 -0500 Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:36454 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655Ab0LMOnh (ORCPT ); Mon, 13 Dec 2010 09:43:37 -0500 Received: from source ([74.125.82.170]) by na3sys009aob103.postini.com ([74.125.148.12]) with SMTP ID DSNKTQYxGAElHhnl6/JCjuyifSMFx4rvBvle@postini.com; Mon, 13 Dec 2010 06:43:37 PST Received: by mail-wy0-f170.google.com with SMTP id 39so8156449wyb.15 for ; Mon, 13 Dec 2010 06:43:36 -0800 (PST) Received: by 10.216.162.84 with SMTP id x62mr4481895wek.106.1292251413273; Mon, 13 Dec 2010 06:43:33 -0800 (PST) From: Nishanth Menon References: <1291395818-8639-1-git-send-email-nm@ti.com> <1291395818-8639-6-git-send-email-nm@ti.com> <2cdf7d3d033ee2c88b6f2d4cfa37d9db@mail.gmail.com> <4D0622FE.2070801@ti.com> <4D062806.6090201@ti.com> <4D062F81.407@ti.com> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4D062F81.407@ti.com> Thread-Index: Acua0y31iOWm7mBVRB6izPQvhDfkNAAAM0OA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Date: Mon, 13 Dec 2010 08:43:32 -0600 Message-ID: <96505dfaee73d6785e153ccf5c2856d3@mail.gmail.com> Subject: RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if < ES1.2 To: Vishwanath Sripathy Cc: linux-omap , Eduardo Valentin , Kevin Hilman , Tony Lindgren Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 13 Dec 2010 14:43:39 +0000 (UTC) diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index ba3c0d6..74842f1 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -933,7 +933,14 @@ void omap3_pm_off_mode_enable(int enable) list_for_each_entry(pwrst, &pwrst_list, node) { pwrst->next_state = state; - omap_set_pwrdm_state(pwrst->pwrdm, state); + if (IS_PM34XX_ERRATUM(SDRC_WAKEUP_ERRATUM_i583) && + pwrst->pwrdm == core_pwrdm) { + omap_set_pwrdm_state(pwrst->pwrdm, PWRDM_POWER_RET); + pr_err("%s: cannot enable Core OFF due to i583\n", + __func__); + } else { + omap_set_pwrdm_state(pwrst->pwrdm, state); + } } }