diff mbox

omap_apollon_2420_defconfig

Message ID 9c9fda240902091754q7f723bf2ha46206e52641297b@mail.gmail.com
State Awaiting Upstream, archived
Headers show

Commit Message

Kyungmin Park Feb. 10, 2009, 1:54 a.m. UTC
Hi,

In the previous patch, it's only fixed host side. But apollon case, it
only used udc, so udc configuration should select USB_OTG_UTILS also.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---


On Tue, Feb 10, 2009 at 5:53 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090209 11:27]:
>> It would be nice to get the last OMAP defconfig in mainline working.
>> It's broken since 2.6.29-rc2-git3 due to this persistent problem:
>>
>> drivers/built-in.o: In function `omap_udc_probe':
>> omap.c:(.init.text+0x30cc): undefined reference to `otg_get_transceiver'
>> omap.c:(.init.text+0x38a4): undefined reference to `otg_put_transceiver'
>
> Hmm, looks like 2bf5fa13fc8e34d7b86307b99f64a24cb7a83852 did not fix it.
> Dave, do you already have a patch for this?
>
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Brownell Feb. 12, 2009, 6:31 a.m. UTC | #1
On Monday 09 February 2009, Kyungmin Park wrote:
> Hi,
> 
> In the previous patch, it's only fixed host side. But apollon case, it
> only used udc, so udc configuration should select USB_OTG_UTILS also.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

... Greg, this should be a 2.6.29-rc patch (buildfix).

> ---
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 3219d13..b26d6e6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -191,6 +191,7 @@ config USB_GADGET_OMAP
>  	boolean "OMAP USB Device Controller"
>  	depends on ARCH_OMAP
>  	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> +	select USB_OTG_UTILS if ARCH_OMAP
>  	help
>  	   Many Texas Instruments OMAP processors have flexible full
>  	   speed USB device controllers, with support for up to 30
> 
> 
> On Tue, Feb 10, 2009 at 5:53 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [090209 11:27]:
> >> It would be nice to get the last OMAP defconfig in mainline working.
> >> It's broken since 2.6.29-rc2-git3 due to this persistent problem:
> >>
> >> drivers/built-in.o: In function `omap_udc_probe':
> >> omap.c:(.init.text+0x30cc): undefined reference to `otg_get_transceiver'
> >> omap.c:(.init.text+0x38a4): undefined reference to `otg_put_transceiver'
> >
> > Hmm, looks like 2bf5fa13fc8e34d7b86307b99f64a24cb7a83852 did not fix it.
> > Dave, do you already have a patch for this?
> >
> > Regards,
> >
> > Tony
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Russell King - ARM Linux Feb. 20, 2009, 8:58 p.m. UTC | #2
On Tue, Feb 10, 2009 at 10:54:25AM +0900, Kyungmin Park wrote:
> In the previous patch, it's only fixed host side. But apollon case, it
> only used udc, so udc configuration should select USB_OTG_UTILS also.

So, it's 10 days later, mainline is still broken.  In fact, this is
now the only ARM defconfig which is failing.

What's happening?  Is someone going to ack this patch?  Is it going
to be submitted to me or is it going to be submitted via some USB
tree?

Sick of chasing people about build errors.  People here need to get
off their lazy backsides, check kautobuild regularly and submit build
fixes.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Feb. 20, 2009, 9:06 p.m. UTC | #3
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090220 12:58]:
> On Tue, Feb 10, 2009 at 10:54:25AM +0900, Kyungmin Park wrote:
> > In the previous patch, it's only fixed host side. But apollon case, it
> > only used udc, so udc configuration should select USB_OTG_UTILS also.
> 
> So, it's 10 days later, mainline is still broken.  In fact, this is
> now the only ARM defconfig which is failing.
> 
> What's happening?  Is someone going to ack this patch?  Is it going
> to be submitted to me or is it going to be submitted via some USB
> tree?

Well it would be nice to get an ack from the USB people, here's mine:

Acked-by: Tony Lindgren <tony@atomide.com>

> Sick of chasing people about build errors.  People here need to get
> off their lazy backsides, check kautobuild regularly and submit build
> fixes.

How about automatic notifications on the failing omap builds sent to
to linux-omap list? The 34xx builds failing because of the compiler
should be filtered out until the compiler is updated though.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Russell King - ARM Linux Feb. 20, 2009, 9:24 p.m. UTC | #4
On Fri, Feb 20, 2009 at 01:06:44PM -0800, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090220 12:58]:
> > On Tue, Feb 10, 2009 at 10:54:25AM +0900, Kyungmin Park wrote:
> > > In the previous patch, it's only fixed host side. But apollon case, it
> > > only used udc, so udc configuration should select USB_OTG_UTILS also.
> > 
> > So, it's 10 days later, mainline is still broken.  In fact, this is
> > now the only ARM defconfig which is failing.

Really, it's actually almost one month later.  I checked.  I brought
this issue up 27th January and then again on 9th February and here we
are *three* *and* *a* *half* *weeks* later no further forward.

This is plain and simple not acceptable.

> > What's happening?  Is someone going to ack this patch?  Is it going
> > to be submitted to me or is it going to be submitted via some USB
> > tree?
> 
> Well it would be nice to get an ack from the USB people, here's mine:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Right, so one ack which is progress.  That still leaves the question
about how the patch gets into mainline.

> > Sick of chasing people about build errors.  People here need to get
> > off their lazy backsides, check kautobuild regularly and submit build
> > fixes.
> 
> How about automatic notifications on the failing omap builds sent to
> to linux-omap list? The 34xx builds failing because of the compiler
> should be filtered out until the compiler is updated though.

Well, 17 days ago, the compiler was upgraded and the OMAP34xx builds
started to complete.  So your statement tells me that you've not looked
at kautobuild for at least the last 17 days.

If you want any features, please talk to the kautobuild people.  I've
nothing to do with kautobuild other than seemingly being the *sole*
person who checks the kautobuild website and chases people when things
get broken.

Having done some research by reading through the kautobuild site, if you
want to be mailed the results, kautobuild has its own mailing list.  See
http://armlinux.simtec.co.uk/kautobuild/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Brownell Feb. 20, 2009, 9:27 p.m. UTC | #5
On Friday 20 February 2009, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090220 12:58]:
> > On Tue, Feb 10, 2009 at 10:54:25AM +0900, Kyungmin Park wrote:
> > > In the previous patch, it's only fixed host side. But apollon case, it
> > > only used udc, so udc configuration should select USB_OTG_UTILS also.
> > 
> > So, it's 10 days later, mainline is still broken.  In fact, this is
> > now the only ARM defconfig which is failing.
> > 
> > What's happening?  Is someone going to ack this patch?  Is it going
> > to be submitted to me or is it going to be submitted via some USB
> > tree?
> 
> Well it would be nice to get an ack from the USB people, here's mine:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

I thought this was already handled ... evidently not, so I
just sent it to Greg as a buildfix.


> > Sick of chasing people about build errors.  People here need to get
> > off their lazy backsides, check kautobuild regularly and submit build
> > fixes.

Actually the *standard* practice involves

 (a) bugs getting reported
 (b) patches getting provided
 (c) nagging until the patches merge

I can't fault anyone for sticking to that process and not
going out of their way to seek out kautobuild issues;
there's already *way* too much to do.


> How about automatic notifications on the failing omap builds sent to
> to linux-omap list? The 34xx builds failing because of the compiler
> should be filtered out until the compiler is updated though.

That's a much better solution.  I'd suggest no more than
one such nag message a week though.


> 
> Tony
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Feb. 20, 2009, 9:40 p.m. UTC | #6
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090220 13:25]:
> On Fri, Feb 20, 2009 at 01:06:44PM -0800, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [090220 12:58]:
> > > On Tue, Feb 10, 2009 at 10:54:25AM +0900, Kyungmin Park wrote:
> > > > In the previous patch, it's only fixed host side. But apollon case, it
> > > > only used udc, so udc configuration should select USB_OTG_UTILS also.
> > > 
> > > So, it's 10 days later, mainline is still broken.  In fact, this is
> > > now the only ARM defconfig which is failing.
> 
> Really, it's actually almost one month later.  I checked.  I brought
> this issue up 27th January and then again on 9th February and here we
> are *three* *and* *a* *half* *weeks* later no further forward.
> 
> This is plain and simple not acceptable.
> 
> > > What's happening?  Is someone going to ack this patch?  Is it going
> > > to be submitted to me or is it going to be submitted via some USB
> > > tree?
> > 
> > Well it would be nice to get an ack from the USB people, here's mine:
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Right, so one ack which is progress.  That still leaves the question
> about how the patch gets into mainline.
> 
> > > Sick of chasing people about build errors.  People here need to get
> > > off their lazy backsides, check kautobuild regularly and submit build
> > > fixes.
> > 
> > How about automatic notifications on the failing omap builds sent to
> > to linux-omap list? The 34xx builds failing because of the compiler
> > should be filtered out until the compiler is updated though.
> 
> Well, 17 days ago, the compiler was upgraded and the OMAP34xx builds
> started to complete.  So your statement tells me that you've not looked
> at kautobuild for at least the last 17 days.

Great, I wonder what other fabulous websites I've forgotten!

> If you want any features, please talk to the kautobuild people.  I've
> nothing to do with kautobuild other than seemingly being the *sole*
> person who checks the kautobuild website and chases people when things
> get broken.
> 
> Having done some research by reading through the kautobuild site, if you
> want to be mailed the results, kautobuild has its own mailing list.  See
> http://armlinux.simtec.co.uk/kautobuild/

OK, I'll take a look at getting some automated warnings from there to
linux-omap list at some point when I get around to it.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 3219d13..b26d6e6 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -191,6 +191,7 @@  config USB_GADGET_OMAP
 	boolean "OMAP USB Device Controller"
 	depends on ARCH_OMAP
 	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
+	select USB_OTG_UTILS if ARCH_OMAP
 	help
 	   Many Texas Instruments OMAP processors have flexible full
 	   speed USB device controllers, with support for up to 30