From patchwork Mon Apr 24 18:12:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9696879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1867C603F2 for ; Mon, 24 Apr 2017 18:12:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12101205A4 for ; Mon, 24 Apr 2017 18:12:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0545328404; Mon, 24 Apr 2017 18:12:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C79D205A4 for ; Mon, 24 Apr 2017 18:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S976587AbdDXSMK (ORCPT ); Mon, 24 Apr 2017 14:12:10 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33894 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S972521AbdDXSMJ (ORCPT ); Mon, 24 Apr 2017 14:12:09 -0400 Received: by mail-oi0-f66.google.com with SMTP id y11so28204068oie.1; Mon, 24 Apr 2017 11:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=n6dVs7uysQj2cXWSnQ9tBLn+jQnoyUxBx7o1yWS3+oo=; b=O4YQL82j/+pFvDNHVGSRZwLbTTJ/9kWio7bh48veB4T5ACIiot0pKxea1SCsMzG/Yj cl7x0Yob8qJEwIJxO/SYuCechvrEre/nN/3OUAT/foOor8c/8VzXoekI2trxocbzkLJN g4KyAbITLpPAKsAbOj3xxe+F2cmbaH9DunzgDDPmx4B1yI6mYpwDBIwnyq+bwXIaoCDg GWpLhJbv5ORRfWxu0IVvbzwJobZmjdf0SW17wXWXIXtVIrspU6Jijyb3COIzr6En9hTe WEjO9cGAEzHoR9T7kgV+5D+uCJoorBfbfOkrPxcOz/rA7fIydC+Iaci6flQHL/Mk3IfV Azcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=n6dVs7uysQj2cXWSnQ9tBLn+jQnoyUxBx7o1yWS3+oo=; b=VuBW14eGRHqrhW4cL8olYn/XMqa8tST7SauvRtpVVddBuU+wV7Xs70nQpum7xD+B4u 2Se++1yI+mnKhiRtJQMclHxZY0hRozh4D6CySGY8/wjnEk3+BLJBHKz4o0xapf5ESty7 TuK2AEkIYbgT1xTYmYCnldes+a+pptYVOhp0vY2brWl8pnJylgTXdaCAlmhev7xfhGhy 12cL/qC8aKBRBUN2VVrQbiiYr4TRIjjNDrXVKCf38OpeSKH4Ffd39vv6YNBlna5IgOPY dmbEOeT74lYXsFbpV0CAEgTivYhIbgdrn+u4hhAyHYMjxX3f5PrkNv7l0QXm2qk064rH S+2Q== X-Gm-Message-State: AN3rC/7VJ5cT/PrxmD+NF6jRrNavDmwy+kf18uSM/NVJuqnUXWSUtFg4 +302K16tRLWkjd93lRZ2a1WUL19TTA== X-Received: by 10.157.39.138 with SMTP id c10mr13324552otb.125.1493057528888; Mon, 24 Apr 2017 11:12:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.20.240 with HTTP; Mon, 24 Apr 2017 11:12:08 -0700 (PDT) In-Reply-To: <20170424174413.GD3780@atomide.com> References: <20170424165104.GC3780@atomide.com> <20170424174413.GD3780@atomide.com> From: Arnd Bergmann Date: Mon, 24 Apr 2017 20:12:08 +0200 X-Google-Sender-Auth: TaXSUWRdGW5txT7w0n2yhfrlqq4 Message-ID: Subject: Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers" To: Tony Lindgren Cc: Grygorii Strashko , Networking , linux-omap@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Apr 24, 2017 at 7:44 PM, Tony Lindgren wrote: > * Arnd Bergmann [170424 10:38]: >> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote: >> > Hi, >> > >> > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") >> > in mainline started triggering the following oops at least on j5eco-evm. >> > >> > Adding CONFIG_PTP_1588_CLOCK to .config solves it, but the oops hints >> > something is wrong with the dependencies.. CONFIG_TI_CPTS defaults to N >> > and not selecting it causes the oops. >> > >> > Any ideas what's needed to properly fix this? >> >> Does your configuration have POSIX_TIMERS enabled? If not, then CPTS >> is now also disabled. There are two issues here that we need to solve: >> >> a) find out why POSIX_TIMERS got disabled, and make sure it's always >> turned on for normal users > > $ make omap2plus_defconfig > ... > CONFIG_POSIX_TIMERS=y > # CONFIG_PTP_1588_CLOCK is not set > > So CONFIG_TI_CPTS is unselectable. Ok, so at least this one is easy to understand, it's a direct consequence of my change, as nothing else will select CONFIG_PTP_1588_CLOCK now. My first try would be this one: >> b) find out what's wrong with the driver when CPTS is disabled. This would >> be an existing problem that you just never saw because CPTS was >> always enabled so far. > > See a) above, yes seems there are two problems here. Ok. Arnd Tested-by: Tony Lindgren --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index 9e631952b86f..8042a7626056 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -76,7 +76,7 @@ config TI_CPSW config TI_CPTS bool "TI Common Platform Time Sync (CPTS) Support" depends on TI_CPSW || TI_KEYSTONE_NETCP - depends on PTP_1588_CLOCK + depends on POSIX_TIMERS ---help--- This driver supports the Common Platform Time Sync unit of the CPSW Ethernet Switch and Keystone 2 1g/10g Switch Subsystem. @@ -87,6 +87,7 @@ config TI_CPTS_MOD tristate depends on TI_CPTS default y if TI_CPSW=y || TI_KEYSTONE_NETCP=y + imply PTP_1588_CLOCK default m config TI_KEYSTONE_NETCP