From patchwork Mon Aug 27 22:12:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 1378501 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D5EA4DF280 for ; Mon, 27 Aug 2012 22:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797Ab2H0WMb (ORCPT ); Mon, 27 Aug 2012 18:12:31 -0400 Received: from na3sys009aog129.obsmtp.com ([74.125.149.142]:35843 "EHLO na3sys009aog129.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754730Ab2H0WM2 (ORCPT ); Mon, 27 Aug 2012 18:12:28 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]) (using TLSv1) by na3sys009aob129.postini.com ([74.125.148.12]) with SMTP ID DSNKUDvwzIctfITXfDerc3yOkvEvFViD7Lbw@postini.com; Mon, 27 Aug 2012 15:12:28 PDT Received: by iakx26 with SMTP id x26so11808523iak.18 for ; Mon, 27 Aug 2012 15:12:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=AkZXSNTDjNQiiZGqRAxOI4C0zdiLp/zR0cxtUke+luQ=; b=UqGi/od+G9u07sw2mYE4XNrLCcOJKoKKgdQ/96H2URFOaXXx01uaGIkbDudhx+B1B+ VuSg0sYcLEZIx+s+Qi78RszSHmMZG4wWjxqz2JQmNaYYKhfrg6iD1zVTz0IE0xBE3UFH wkgMR4jY9SyijV7gUXRbpOQ4TJPiqBQBDc+62Lt7xvTw2Qh2C51mLZmqadNlM7fuu5pJ SAIy2hZlMYreTbD3MBmBAtEcQl+m/ci71ucCV59xbwSbO3Xyl9RXK9jicVBhLwNmsT/0 GBGZ5RNF2rQ36GrnZiIBTNngetK8JXhwakN08pzY7+pLbYUoGyEv74pIEW56XS/MS8b3 0uMA== Received: by 10.50.85.228 with SMTP id k4mr11838388igz.22.1346105547695; Mon, 27 Aug 2012 15:12:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.65.85 with HTTP; Mon, 27 Aug 2012 15:12:07 -0700 (PDT) In-Reply-To: <20120827220254.GA783@harshnoise.musicnaut.iki.fi> References: <1346101403-5882-1-git-send-email-aaro.koskinen@iki.fi> <20120827220254.GA783@harshnoise.musicnaut.iki.fi> From: "Shilimkar, Santosh" Date: Mon, 27 Aug 2012 15:12:07 -0700 Message-ID: Subject: Re: [PATCH] arm: omap: ratelimit omap_l3_smx error log spam To: Aaro Koskinen Cc: tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Gm-Message-State: ALoCoQkM4FC36pBGGCqzSXSsKGpty5w18F1hOcN3w1AfrTJiT4BHwkbpbgr1g/XobLTkipFyifDM Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Aug 27, 2012 at 3:02 PM, Aaro Koskinen wrote: > Hi, > > On Mon, Aug 27, 2012 at 02:35:57PM -0700, Shilimkar, Santosh wrote: >> > - pr_err("%s seen by %s %s at address %x\n", >> > + pr_err_ratelimited("%s seen by %s %s at address %x\n", >> > omap3_l3_code_string(code), >> > omap3_l3_initiator_string(initid), >> > multi ? "Multiple Errors" : "", address); >> > - WARN_ON(1); >> > + WARN_ON_ONCE(1); >> > >> The issue needs to be fixed instead of WARN_ON_ONCE() and then >> just moving ahead. Interconnect in bad states is really bad state and you >> won't have reliable operations post that on SOC. > > How printing megabytes of identical stack traces helps anything? > It just says repeatedly and loudly... Fix the issue :-) > This has been there always (since the L3 driver was added) on every boot > with N950/N9 (which BTW are HS devices, not sure if that has anything > to do with it). There is no apparent effect on device functionality, > at least nothing unusual has been observed... > I assumed this is secure device when I saw the SRAM memset is causing the issue. > Is there any documentation how to interpret and debug this error report? > The issue could be, there is memset tried on Secure portion of SRAM or CPU speculatively accessed adjacent SRAM region of public SRAM which is secure and hence the error. If you just bypass the SRAM init [1], does the issue go away ? Regards Santosh [1] --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c index 766181c..305e6de 100644 --- a/arch/arm/plat-omap/sram.c +++ b/arch/arm/plat-omap/sram.c @@ -384,6 +384,7 @@ static inline int am33xx_sram_init(void) int __init omap_sram_init(void) { +#if 0 omap_detect_sram(); omap_map_sram(); @@ -397,6 +398,6 @@ int __init omap_sram_init(void) am33xx_sram_init(); else if (cpu_is_omap34xx()) omap34xx_sram_init(); - +#endif return 0; }