From patchwork Fri Apr 26 06:27:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2490991 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 7CB7A3FC64 for ; Fri, 26 Apr 2013 06:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758971Ab3DZG1M (ORCPT ); Fri, 26 Apr 2013 02:27:12 -0400 Received: from mail-bk0-f54.google.com ([209.85.214.54]:57027 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758909Ab3DZG1L (ORCPT ); Fri, 26 Apr 2013 02:27:11 -0400 Received: by mail-bk0-f54.google.com with SMTP id q11so1596015bkw.13 for ; Thu, 25 Apr 2013 23:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=qm4VcLf2FG+rdLOORlpTkbnMAs99eovwjVfV7L3Q/0E=; b=hB4LQ7GbWQATeY6OfirOuiKhCbEnGiNwJzK29TliPdzqAHeSXQQuA+5rVfq4G334dg SRZOuv/3RcKRL5k5kTTfbegsqkIKIbyvaN5Cjrn+wB6Su1YJmf2pNPvd5EoJBITOozFB DVj3oPvsY+rrFpXKdiykXnoUSm4spnCxOXto7VWtV5WtrYxSQeGOQil/ROwDA9Q/3yxf crLpBpPpAhBwTdRmH4CZGHtBfknhNJLPbCT49xTgv2nK5CIdFgJukxVvdkshg7WKlsYX OVcFlm8V+tElAAQUaQ3nbLLxeYrhQpxFUcZJUtdpegj2FsaHNTmXUyEObNmZH7Hq6rNL s9kQ== MIME-Version: 1.0 X-Received: by 10.204.162.8 with SMTP id t8mr17702378bkx.95.1366957629826; Thu, 25 Apr 2013 23:27:09 -0700 (PDT) Received: by 10.204.175.10 with HTTP; Thu, 25 Apr 2013 23:27:09 -0700 (PDT) Date: Fri, 26 Apr 2013 14:27:09 +0800 Message-ID: Subject: [PATCH] usb: musb: omap2430: add missing platform_device_put() on error in omap2430_probe() From: Wei Yongjun To: balbi@ti.com, gregkh@linuxfoundation.org, grant.likely@linaro.org, rob.herring@calxeda.com, kishon@ti.com Cc: yongjun_wei@trendmicro.com.cn, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Wei Yongjun Add the missing platform_device_put() before return from omap2430_probe() in the error handling case. Introduced by commit ca784be36cc725bca9b526eba342de7550329731 (usb: start using the control module driver) Signed-off-by: Wei Yongjun --- drivers/usb/musb/omap2430.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 3551f1a..628b93f 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev) glue->control_otghs = omap_get_control_dev(); if (IS_ERR(glue->control_otghs)) { dev_vdbg(&pdev->dev, "Failed to get control device\n"); - return -ENODEV; + ret = PTR_ERR(glue->control_otghs); + goto err2; } } else { glue->control_otghs = ERR_PTR(-ENODEV);