From patchwork Sat Sep 26 08:09:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 50216 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8Q89aQh029838 for ; Sat, 26 Sep 2009 08:09:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbZIZIJa (ORCPT ); Sat, 26 Sep 2009 04:09:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751422AbZIZIJa (ORCPT ); Sat, 26 Sep 2009 04:09:30 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:41243 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbZIZIJ2 convert rfc822-to-8bit (ORCPT ); Sat, 26 Sep 2009 04:09:28 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id n8Q89Ji8023865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 Sep 2009 03:09:21 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id n8Q89E9C009820; Sat, 26 Sep 2009 13:39:15 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde71.ent.ti.com ([172.24.170.149]) with mapi; Sat, 26 Sep 2009 13:39:14 +0530 From: "Shilimkar, Santosh" To: Tony Lindgren , Paul Walmsley CC: Kevin Hilman , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Sat, 26 Sep 2009 13:39:12 +0530 Subject: OMAP4430 build broken on latest mainline/linux-omap head Thread-Topic: OMAP4430 build broken on latest mainline/linux-omap head Thread-Index: Aco+gKITRfM0BbW3Rxa4qi+hA30A6w== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Tony, OMAP4430 board build is breaking on the latest mainline head because of couple of issues. 1. The serial.c merge conflict issue below wasn't fixed correctly :( Related link: http://article.gmane.org/gmane.linux.ports.arm.omap/23341 2. Pauls below series breaks build as well. [PATCH 00/13] OMAP PM, clock, and SDRC updates for the 2.6.32 merge window Paul, Can you fix the same please? I don't have the correct " cm-regbits-4xxx.h" file to generate the patch. *************************************************** CC arch/arm/mach-omap2/control.o CC arch/arm/mach-omap2/mux.o CC arch/arm/mach-omap2/devices.o CC arch/arm/mach-omap2/serial.o CC arch/arm/mach-omap2/gpmc.o CC arch/arm/mach-omap2/timer-gp.o CC arch/arm/mach-omap2/omap-smp.o AS arch/arm/mach-omap2/omap-headsmp.o CC arch/arm/mach-omap2/timer-mpu.o CC arch/arm/mach-omap2/cm4xxx.o arch/arm/mach-omap2/cm4xxx.c:25:29: error: cm-regbits-4xxx.h: No such file or directory arch/arm/mach-omap2/cm4xxx.c: In function 'omap4_cm_wait_idlest_ready': arch/arm/mach-omap2/cm4xxx.c:61: error: implicit declaration of function 'omap4_cm_read_mod_reg' arch/arm/mach-omap2/cm4xxx.c:62: error: 'OMAP4_CM_CLKCTRL_DREG' undeclared (first use in this function) arch/arm/mach-omap2/cm4xxx.c:62: error: (Each undeclared identifier is reported only once arch/arm/mach-omap2/cm4xxx.c:62: error: for each function it appears in.) make[1]: *** [arch/arm/mach-omap2/cm4xxx.o] Error 1 make: *** [arch/arm/mach-omap2] Error 2 ***************************************************** Tony, Patch regarding one 1. is below. From 3abd16f9b81dc55a2d894175d4a75f5a40c0fdd5 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Sat, 26 Sep 2009 13:07:39 +0530 Subject: [PATCH] ARM: OMAP4: Fix build break because of merge conflict On the latest mainline head 2.6.31 (commit:6d7f18f6), OMAP4430 board build is broken. This was mainly because of merge conflict which wasn't resolved correctly. The related patch and issue was discussed here. http://article.gmane.org/gmane.linux.ports.arm.omap/23341 Signed-off-by: Santosh Shilimkar Cc: Kevin Hilman Cc: Tony Lindgren --- arch/arm/mach-omap2/serial.c | 14 ++------------ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index 3a529c7..54dfeb5 100644 --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -109,16 +109,6 @@ static struct plat_serial8250_port serial_platform_data2[] = { .regshift = 2, .uartclk = OMAP24XX_BASE_BAUD * 16, }, { -#ifdef CONFIG_ARCH_OMAP4 - .membase = IO_ADDRESS(OMAP_UART4_BASE), - .mapbase = OMAP_UART4_BASE, - .irq = 70, - .flags = UPF_BOOT_AUTOCONF, - .iotype = UPIO_MEM, - .regshift = 2, - .uartclk = OMAP24XX_BASE_BAUD * 16, - }, { -#endif .flags = 0 } }; @@ -126,7 +116,7 @@ static struct plat_serial8250_port serial_platform_data2[] = { #ifdef CONFIG_ARCH_OMAP4 static struct plat_serial8250_port serial_platform_data3[] = { { - .membase = IO_ADDRESS(OMAP_UART4_BASE), + .membase = OMAP2_IO_ADDRESS(OMAP_UART4_BASE), .mapbase = OMAP_UART4_BASE, .irq = 70, .flags = UPF_BOOT_AUTOCONF, @@ -579,7 +569,7 @@ static struct omap_uart_state omap_uart[OMAP_MAX_NR_PORTS] = { { .pdev = { .name = "serial8250", - .id = 3 + .id = 3, .dev = { .platform_data = serial_platform_data3, },