From patchwork Sun Jun 19 19:00:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leigh Brown X-Patchwork-Id: 895072 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5JJAOFx013016 for ; Sun, 19 Jun 2011 19:10:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754684Ab1FSTKW (ORCPT ); Sun, 19 Jun 2011 15:10:22 -0400 Received: from doppler.thel33t.co.uk ([193.110.88.198]:38312 "EHLO doppler.thel33t.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754651Ab1FSTKW (ORCPT ); Sun, 19 Jun 2011 15:10:22 -0400 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 19 Jun 2011 19:10:24 +0000 (UTC) X-Greylist: delayed 605 seconds by postgrey-1.27 at vger.kernel.org; Sun, 19 Jun 2011 15:10:21 EDT Received: from doppler.thel33t.co.uk (localhost [127.0.0.1]) by doppler.thel33t.co.uk (Postfix) with ESMTP id 1BF5D4A296; Sun, 19 Jun 2011 20:00:13 +0100 (BST) MIME-Version: 1.0 Date: Sun, 19 Jun 2011 19:00:13 +0000 From: Leigh Brown To: Felipe Balbi Cc: Dmitry Torokhov , , Linux OMAP Mailing List Subject: Re: [PATCH] input: keypad: lm8323: convert to threaded IRQ In-Reply-To: <1307999812-3802-1-git-send-email-balbi@ti.com> References: <1307999812-3802-1-git-send-email-balbi@ti.com> Message-ID: X-Sender: leigh@solinno.co.uk User-Agent: Roundcube Webmail/0.5.3 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Felipe, Many thanks for trying to assist me with my problem. To recap, I'm seeing the keypad lock-up on my N810 using this driver, when I type quickly. I tried your patch, and it doesn't fix the issue. However, I've read the datasheet for the lm8323 and it looks to me like the interrupt should be level rather than edge triggered. The following additional patch makes things work for me. I couldn't tell you if it's the correct thing to do but I can no longer cause the keypad to lock-up by typing too fast. Regards, Leigh. diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c index 3b21f42..ab0acaf 100644 --- a/drivers/input/keyboard/lm8323.c +++ b/drivers/input/keyboard/lm8323.c @@ -734,7 +734,7 @@ static int __devinit lm8323_probe(struct i2c_client *client, } err = request_threaded_irq(client->irq, NULL, lm8323_irq, - IRQF_TRIGGER_FALLING, "lm8323", lm); + IRQF_TRIGGER_LOW|IRQF_ONESHOT, "lm8323", lm); if (err) { dev_err(&client->dev, "could not get IRQ %d\n", client->irq);