From patchwork Mon Oct 8 01:42:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 1563371 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 34CDE3FD9C for ; Mon, 8 Oct 2012 01:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750994Ab2JHBnA (ORCPT ); Sun, 7 Oct 2012 21:43:00 -0400 Received: from utopia.booyaka.com ([74.50.51.50]:54173 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745Ab2JHBm7 (ORCPT ); Sun, 7 Oct 2012 21:42:59 -0400 Received: (qmail 27389 invoked by uid 1019); 8 Oct 2012 01:42:59 -0000 Date: Mon, 8 Oct 2012 01:42:59 +0000 (UTC) From: Paul Walmsley To: linux-omap@vger.kernel.org cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org, grinberg@compulab.co.il Subject: Re: ARM: OMAP: fix new sparse warnings In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Here's an updated version of this one that drops the debug-devices.c change. That will be dealt with in a separate patch. - Paul From: Paul Walmsley Date: Sun, 7 Oct 2012 13:10:00 -0600 Subject: [PATCH] ARM: OMAP: omap3evm: fix new sparse warning Commit e54adb1e79762d3591459e5b0e9b9ff578e33fdb ("ARM: OMAP: omap3evm: cleanup revision bits") adds a new sparse[1] warning: arch/arm/mach-omap2/board-omap3evm.c:90:4: warning: symbol 'get_omap3_evm_rev' was not declared. Should it be static? This symbol no longer appears to be used outside this file, so mark it static and remove the export. ... 1. https://sparse.wiki.kernel.org/index.php/Main_Page Signed-off-by: Paul Walmsley Cc: Igor Grinberg Cc: Tony Lindgren --- arch/arm/mach-omap2/board-omap3evm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c index c64e565..184ef21 100644 --- a/arch/arm/mach-omap2/board-omap3evm.c +++ b/arch/arm/mach-omap2/board-omap3evm.c @@ -88,11 +88,10 @@ enum { static u8 omap3_evm_version; -u8 get_omap3_evm_rev(void) +static u8 get_omap3_evm_rev(void) { return omap3_evm_version; } -EXPORT_SYMBOL(get_omap3_evm_rev); static void __init omap3_evm_get_revision(void) {